Composition: Hide contextMenu on composed storybooks #29803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+277
to
+279
| refId === 'storybook_internal' | ||
| ? useContextMenu(item, statusLinks, api) | ||
| : { node: null, onMouseEnter: () => {} }; |
There was a problem hiding this comment.
style: consider using a constant for 'storybook_internal' to avoid magic strings
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8154eed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
JReinhold
approved these changes
Dec 4, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29686
What I did
I ensured that the code for creating the contextMenu never runs for refs
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
I manually verified the UI looks correct by:
It looked like this (icons are from a reffed storybook):
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Implemented a fix to prevent context menu from appearing in referenced (composed) Storybooks by modifying the sidebar Tree component's menu behavior.
code/core/src/manager/components/sidebar/Tree.tsxto check forrefId === 'storybook_internal'before showing context menu