Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Temporarily disable CRA sandboxes #29832

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 6, 2024

Closes #

What I did

React 19 upstream issues have been occurring in our CI so for now we disable the CRA sandboxes.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.7 MB 77.7 MB -4.28 kB -3.73 0%
initSize 130 MB 130 MB 14.7 kB -1.2 0%
diffSize 52.4 MB 52.5 MB 19 kB 1.94 0%
buildSize 6.75 MB 6.75 MB 0 B -0.65 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B 1.33 0%
buildSbPreviewSize 0 B 0 B 0 B -0.65 -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.57 MB 3.57 MB 0 B -0.65 0%
buildPreviewSize 3.19 MB 3.19 MB 0 B 0.65 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.8s 17.9s 11.1s 0.39 62.1%
generateTime 25.5s 19.6s -5s -842ms -0.61 -29.7%
initTime 15.9s 13.3s -2s -573ms -0.25 -19.2%
buildTime 8.1s 10.1s 2s 1.03 20%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.4s 4.9s -412ms -0.34 -8.3%
devManagerResponsive 3.8s 3.5s -287ms -0.38 -8%
devManagerHeaderVisible 555ms 647ms 92ms 0.91 14.2%
devManagerIndexVisible 629ms 688ms 59ms 0.43 8.6%
devStoryVisibleUncached 1.9s 2s 76ms 1.07 3.8%
devStoryVisible 627ms 690ms 63ms 0.48 9.1%
devAutodocsVisible 408ms 540ms 132ms 0.52 24.4%
devMDXVisible 562ms 577ms 15ms 0.7 2.6%
buildManagerHeaderVisible 549ms 585ms 36ms 0.18 6.2%
buildManagerIndexVisible 622ms 656ms 34ms 0.23 5.2%
buildStoryVisible 498ms 536ms 38ms 0.01 7.1%
buildAutodocsVisible 440ms 570ms 130ms 1.9 🔺22.8%
buildMDXVisible 404ms 559ms 155ms 2.68 🔺27.7%

Greptile Summary

Temporarily disables Create React App (CRA) sandboxes in the test suite due to React 19 compatibility issues, with corresponding adjustments to CI parallelism counts.

  • Commented out cra/default-ts and cra/default-js from normal and daily test runs in code/lib/cli-storybook/src/sandbox-templates.ts
  • Reduced parallelism in CI jobs from 13 to 8 for create/build sandboxes in .circleci/config.yml
  • Reduced parallelism for e2e and test-runner jobs proportionally
  • CRA templates remain defined but are excluded from test execution until React 19 issues are resolved

@yannbf yannbf added build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged. labels Dec 6, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Dec 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 32c8e43. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@yannbf yannbf added ci:merged Run the CI jobs that normally run when merged. patch:yes Bugfix & documentation PR that need to be picked to main branch and removed ci:merged Run the CI jobs that normally run when merged. labels Dec 6, 2024
@yannbf yannbf merged commit ed4fb2d into next Dec 6, 2024
72 of 76 checks passed
@yannbf yannbf deleted the yann/disable-cra-sandboxes branch December 6, 2024 13:06
@yannbf yannbf added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 20, 2024
yannbf added a commit that referenced this pull request Dec 20, 2024
Build: Temporarily disable CRA sandboxes
(cherry picked from commit ed4fb2d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged. patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants