Addon Test: Fix printing null% for coverage

[ghengeveld]

What I did

Fixes this issue by not printing anything at all if the value is null or undefined:

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name	before	after	diff	z	%
createSize	0 B	0 B	0 B	-	-
generateSize	77.7 MB	77.7 MB	48 B	1.11	0%
initSize	136 MB	136 MB	48 B	1.11	0%
diffSize	58.4 MB	58.4 MB	0 B	1.11	0%
buildSize	7.24 MB	7.24 MB	0 B	0.9	0%
buildSbAddonsSize	1.88 MB	1.88 MB	0 B	0.9	0%
buildSbCommonSize	195 kB	195 kB	0 B	-	0%
buildSbManagerSize	1.86 MB	1.86 MB	0 B	0.83	0%
buildSbPreviewSize	0 B	0 B	0 B	-	-
buildStaticSize	0 B	0 B	0 B	-	-
buildPrebuildSize	3.93 MB	3.93 MB	0 B	0.9	0%
buildPreviewSize	3.3 MB	3.3 MB	0 B	0.89	0%
testBuildSize	0 B	0 B	0 B	-	-
testBuildSbAddonsSize	0 B	0 B	0 B	-	-
testBuildSbCommonSize	0 B	0 B	0 B	-	-
testBuildSbManagerSize	0 B	0 B	0 B	-	-
testBuildSbPreviewSize	0 B	0 B	0 B	-	-
testBuildStaticSize	0 B	0 B	0 B	-	-
testBuildPrebuildSize	0 B	0 B	0 B	-	-
testBuildPreviewSize	0 B	0 B	0 B	-	-

name	before	after	diff	z	%
createTime	8s	24.3s	16.3s	1.22	67%
generateTime	20.2s	20s	-174ms	-0.31	-0.9%
initTime	14.5s	13.9s	-610ms	-0.22	-4.4%
buildTime	11.9s	8.2s	-3s -647ms	-0.85	-44.2%
testBuildTime	0ms	0ms	0ms	-	-
devPreviewResponsive	5.6s	5.1s	-539ms	-0.04	-10.6%
devManagerResponsive	4.1s	3.7s	-428ms	-0.27	-11.5%
devManagerHeaderVisible	748ms	584ms	-164ms	-0.11	-28.1%
devManagerIndexVisible	770ms	614ms	-156ms	-0.37	-25.4%
devStoryVisibleUncached	1.9s	1.9s	5ms	0.77	0.3%
devStoryVisible	792ms	612ms	-180ms	-0.4	-29.4%
devAutodocsVisible	501ms	540ms	39ms	0.29	7.2%
devMDXVisible	578ms	514ms	-64ms	-0.18	-12.5%
buildManagerHeaderVisible	642ms	635ms	-7ms	0.57	-1.1%
buildManagerIndexVisible	744ms	728ms	-16ms	0.46	-2.2%
buildStoryVisible	603ms	593ms	-10ms	0.71	-1.7%
buildAutodocsVisible	504ms	480ms	-24ms	0.59	-5%
buildMDXVisible	475ms	476ms	1ms	0.34	0.2%

Greptile Summary

This PR fixes an issue in the test addon where coverage percentages were incorrectly displaying "null%" when no coverage data was available.

• Modified code/addons/test/src/components/TestProviderRender.tsx to prevent displaying percentage when value is null/undefined
• Potential logical error in fix implementation with nullish coalescing operator that could still display "null%"
• Missing test coverage to verify the fix works as intended
• Affects coverage reporting display in Storybook's test addon UI

[greptile-apps]

_{1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile}

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 312047f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 2 targets

• nx affected -t check -c production --parallel=7
• nx run-many -t build -c production --parallel=3

---

Sent with 💌 from NxCloud.

[storybook-pr-benchmarking]

Package Benchmarks

^{Commit: 312047f, ran on 16 December 2024 at 13:54:54 UTC}

No significant changes detected, all good. 👏