Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Use correct storybook internals import in automigration #30290

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 17, 2025

Closes #

What I did

After fixing the logic in the local-rules linter rule, it detected a problem, which is now fixed.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Based on the provided information, I'll create a concise summary of the pull request changes:

Updates import path for Storybook internal types in the CLI automigration system to fix a linting issue.

  • Changed import path from @storybook/core/common to storybook/internal/common in code/lib/cli-storybook/src/automigrate/fixes/missing-storybook-dependencies.ts
  • Maintains same functionality while aligning with internal import standards
  • Part of broader effort to enforce stricter linting rules across codebase
  • Affects type imports only, no runtime behavior changes

@yannbf yannbf added maintenance User-facing maintenance tasks cli ci:normal labels Jan 17, 2025
@yannbf yannbf self-assigned this Jan 17, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Jan 17, 2025

View your CI Pipeline Execution ↗ for commit 267c4c4.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 43s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-17 11:02:15 UTC

@yannbf yannbf merged commit bc7d84b into next Jan 17, 2025
24 of 32 checks passed
@yannbf yannbf deleted the yann/fix-lint-issue branch January 17, 2025 11:09
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants