Fix inconsistencies in the background add-on README #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexpunk
commented
Feb 25, 2018
| @@ -3,13 +3,13 @@ | |||
| [](https://circleci.com/gh/storybooks/storybook) | |||
| [](https://www.codefactor.io/repository/github/storybooks/storybook) | |||
| [](https://snyk.io/test/github/storybooks/storybook/8f36abfd6697e58cd76df3526b52e4b9dc894847) | |||
| [](https://bettercodehub.com/results/storybooks/storybook) [](https://codecov.io/gh/storybooks/storybook) | |||
There was a problem hiding this comment.
This was just my editor removing trailing whitespace.
Codecov Report
@@ Coverage Diff @@
## master #3080 +/- ##
======================================
Coverage 35.6% 35.6%
======================================
Files 420 420
Lines 9889 9889
Branches 818 847 +29
======================================
Hits 3521 3521
- Misses 5878 5882 +4
+ Partials 490 486 -4
Continue to review full report at Codecov.
|
Hypnosphi
approved these changes
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
It looks like the text for the background README file was copy/pasted from the centered add-on and some text was left unchanged.
What I did
I updated the text to describe the background add-on instead of the centered add-on. I also updated the installation command to match the rest of the add-ons.
How to test
N/A
Is this testable with jest or storyshots?
No
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
This is an update to the documentation.
If your answer is yes to any of these, please make sure to include it in your PR.