Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: use resolveLoader from cliCommonConfig #3251

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: Angular CLI webpack config uses loaders as plain strings (e.g. use: 'sass-loader'). By default that means that webpack will try to resolve this loader relative to app root directory. Sometimes it happens to work, sometimes it doesn't

To deal with it, angular CLI adds resolveLoader option which we should use as well

@Hypnosphi Hypnosphi added bug configuration babel / webpack angular patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 21, 2018
@Hypnosphi Hypnosphi requested a review from igor-dv March 21, 2018 00:55
@Hypnosphi Hypnosphi mentioned this pull request Mar 21, 2018
4 tasks
@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #3251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3251   +/-   ##
=======================================
  Coverage   35.86%   35.86%           
=======================================
  Files         440      440           
  Lines        9682     9682           
  Branches      897      907   +10     
=======================================
  Hits         3472     3472           
+ Misses       5650     5630   -20     
- Partials      560      580   +20
Impacted Files Coverage Δ
app/angular/src/server/angular-cli_config.js 0% <ø> (ø) ⬆️
app/vue/src/server/utils.js 0% <0%> (-100%) ⬇️
addons/actions/src/lib/util/prepareArguments.js 57.14% <0%> (ø) ⬆️
addons/info/src/components/types/PropertyLabel.js 78.94% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/search_box.js 23.52% <0%> (ø) ⬆️
addons/storysource/src/loader/index.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 33.96% <0%> (ø) ⬆️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
...ns/viewport/src/manager/components/viewportInfo.js 33.33% <0%> (ø) ⬆️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ff58e...2c71745. Read the comment docs.

Copy link
Member

@igor-dv igor-dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hypnosphi Hypnosphi merged commit 6d21615 into master Mar 21, 2018
@Hypnosphi Hypnosphi deleted the angular-resolve-loaders branch March 21, 2018 10:12
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 29, 2018
Hypnosphi added a commit that referenced this pull request Mar 29, 2018
Angular: use resolveLoader from cliCommonConfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug configuration babel / webpack patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants