Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webpack-hot-middleware to fix HMR #3463

Merged
merged 1 commit into from
Apr 21, 2018
Merged

Update webpack-hot-middleware to fix HMR #3463

merged 1 commit into from
Apr 21, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: #3454

@Hypnosphi
Update webpack-hot-middleware
2d5f92d 
(cherry picked from commit 3ef453b)
@Hypnosphi Hypnosphi added dependencies:update patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 21, 2018
@codecov
Copy link

codecov bot commented Apr 21, 2018 •
edited
Loading

Codecov Report

Merging #3463 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3463   +/-   ##
=======================================
  Coverage   37.14%   37.14%           
=======================================
  Files         465      465           
  Lines       10320    10320           
  Branches      924      934   +10     
=======================================
  Hits         3833     3833           
- Misses       5933     5937    +4     
+ Partials      554      550    -4
Impacted Files Coverage Δ
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
.../viewport/src/manager/components/SelectViewport.js 18.18% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Button.js 11.9% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 24.21% <0%> (ø) ⬆️
app/angular/src/server/angular-cli_config.js 0% <0%> (ø) ⬆️
...t-native/src/preview/components/StoryView/index.js 0% <0%> (ø) ⬆️
addons/info/src/components/makeTableComponent.js 67.46% <0%> (ø) ⬆️
addons/info/src/components/types/Enum.js 0% <0%> (ø) ⬆️
addons/storyshots/src/rn/loader.js 53.33% <0%> (ø) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e8e29...2d5f92d. Read the comment docs.

@Hypnosphi Hypnosphi merged commit cdb2ded into master Apr 21, 2018
@Hypnosphi Hypnosphi deleted the update-webpack-hot-middleware branch April 21, 2018 17:30
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 27, 2018
Hypnosphi added a commit that referenced this pull request Apr 27, 2018
@Hypnosphi
Merge pull request #3463 from storybooks/update-webpack-hot-middleware
5320fb3 
Update webpack-hot-middleware to fix HMR
# Conflicts:
#	app/angular/package.json
#	app/mithril/package.json
#	app/polymer/package.json
#	app/react-native/package.json
#	app/react/package.json
#	app/vue/package.json
#	lib/core/package.json
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielduan danielduan danielduan approved these changes

@alterx alterx Awaiting requested review from alterx alterx is a code owner

@Gongreg Gongreg Awaiting requested review from Gongreg

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@kazupon kazupon Awaiting requested review from kazupon kazupon is a code owner

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg

@naipath naipath Awaiting requested review from naipath

@ndelangen ndelangen Awaiting requested review from ndelangen

@rmevans9 rmevans9 Awaiting requested review from rmevans9

@shilman shilman Awaiting requested review from shilman shilman is a code owner

@thomasbertet thomasbertet Awaiting requested review from thomasbertet thomasbertet is a code owner

@tmeasday tmeasday Awaiting requested review from tmeasday tmeasday is a code owner

Assignees
No one assigned
Labels
dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hypnosphi @danielduan @phated