Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knobs: add escapeHTML option; use it by default in Vue, Angular, and Polymer #3473

Merged
merged 4 commits into from
Apr 22, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: #3471

Those frameworks allow rendering of plain HTML, so user input should be escaped

@codecov
Copy link

codecov bot commented Apr 22, 2018

Codecov Report

Merging #3473 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3473      +/-   ##
==========================================
+ Coverage   37.56%   37.56%   +<.01%     
==========================================
  Files         459      459              
  Lines       10235    10237       +2     
  Branches      914      920       +6     
==========================================
+ Hits         3845     3846       +1     
- Misses       5829     5850      +21     
+ Partials      561      541      -20
Impacted Files Coverage Δ
addons/knobs/src/angular/index.js 0% <ø> (ø) ⬆️
addons/knobs/src/polymer/index.js 0% <ø> (ø) ⬆️
addons/knobs/src/vue/index.js 24.13% <ø> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 57.44% <0%> (ø) ⬆️
addons/knobs/src/base.js 10.52% <0%> (-0.59%) ⬇️
addons/knobs/src/KnobManager.js 85% <100%> (+0.78%) ⬆️
.../viewport/src/manager/components/RotateViewport.js 22.72% <0%> (ø) ⬆️
addons/info/src/components/types/proptypes.js 88.88% <0%> (ø) ⬆️
addons/actions/src/lib/types/infinity/index.js 80% <0%> (ø) ⬆️
...modules/ui/components/stories_panel/text_filter.js 36.11% <0%> (ø) ⬆️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df47a4...dcad904. Read the comment docs.

@Hypnosphi Hypnosphi changed the title Text knob: add escapeHTML option; use it by default in Vue, Angular, and Polymer Knobs: add escapeHTML option; use it by default in Vue, Angular, and Polymer Apr 22, 2018
@Hypnosphi Hypnosphi merged commit 961a760 into master Apr 22, 2018
@Hypnosphi Hypnosphi deleted the fix-xss branch April 22, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants