-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't try to access the devtools hook if we are cross-origin #3485
Conversation
We do a similar thing in Vue, it probably needs the check as well |
@Hypnosphi can you explain the chromatic diff? Seems like your handywork no? 😀 |
Sure it is, but I have no idea why chromatic doesn't allow to approve it |
Yeah it looks like the The reason we can't approve the build for this PR comes down to the fact Chromatic's branch detection has been messed up by the change to TeamCity. Hopefully #3477 will resolve that. I'll add the Vue check on this PR and rebase off current master, hopefully that'll sort out the chromatic thing. |
This throws an exception and kills storybook in non-standard cases (like Chromatic's live mode). cc @ndelangen -- I think you saw this.
4620ca7
to
279d4f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #3485 +/- ##
==========================================
- Coverage 37.41% 37.41% -0.01%
==========================================
Files 455 455
Lines 10294 10297 +3
Branches 945 930 -15
==========================================
+ Hits 3852 3853 +1
- Misses 5861 5869 +8
+ Partials 581 575 -6
Continue to review full report at Codecov.
|
Any idea what's happening with these |
Happy to merge this and fix the Chromatic problems separately of course. |
Note I accidentally pushed 8984572 to I can't force push to remove it from history, I'm inclined to just leave it, LMK if that's bad @storybooks/team team |
Oh, that's probably because the images are random, we need to replace them with static placeholders |
Or we can just ignore then in Chromatic if it is too hard to do that |
But yeah, using https://placehold.it or the like is probably fine? |
Sure |
This throws an exception and kills storybook in non-standard cases (like Chromatic's live mode). cc @ndelangen -- I think you saw this.