Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace decorate with decorateAction #3538

Merged
merged 1 commit into from
May 7, 2018
Merged

Replace decorate with decorateAction #3538

merged 1 commit into from
May 7, 2018

Conversation

fvilers
Copy link
Contributor

@fvilers fvilers commented May 7, 2018

Issue: decorate is undefined

What I did

Rename decorate with decorateAction.

How to test

No tests, only documentation update.

For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

On version @storybook/addon-actions@3.4.3 `decorate` is undefined but I found that `decorateAction` is the method I was looking for.
@fvilers fvilers requested a review from rhalff as a code owner May 7, 2018 15:28
@fvilers fvilers changed the title Remplace decorate with decorateAction Replace decorate with decorateAction May 7, 2018
@Hypnosphi Hypnosphi added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 7, 2018
@codecov
Copy link

codecov bot commented May 7, 2018

Codecov Report

Merging #3538 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3538   +/-   ##
=======================================
  Coverage   37.37%   37.37%           
=======================================
  Files         492      492           
  Lines       10774    10774           
  Branches      948      983   +35     
=======================================
  Hits         4027     4027           
+ Misses       6173     6136   -37     
- Partials      574      611   +37
Impacted Files Coverage Δ
lib/ui/src/modules/ui/containers/shortcuts_help.js 25% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Info.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Tags.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Item.js 0% <0%> (ø) ⬆️
...ddons/actions/src/components/ActionLogger/index.js 0% <0%> (ø) ⬆️
lib/core/src/client/preview/reducer.js 37.5% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
lib/core/src/client/preview/subscriptions_store.js 68.96% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/index.js 18.18% <0%> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25731f...83e158f. Read the comment docs.

@Hypnosphi Hypnosphi merged commit e977807 into storybookjs:master May 7, 2018
@fvilers fvilers deleted the patch-1 branch May 8, 2018 11:38
@Hypnosphi Hypnosphi removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants