Added basic authentication option

[tommoor]

For those that would like to self publish their storybook to Heroku or a similar service but have some authentication. This adds simple --username and --password args to the start-storybook command.

[arunoda]

Storybook is not suppose to run this way.
This is a dev server and it has no any production level optimizations.

I suggest you to do this outside of storybook. Export your storybook as a static site, then add basic auth when serving that.

[tommoor]

That's a shame - no one's talking about production here, just making the
dev server accessible online for teammates to review.

On Sun, Aug 28, 2016 at 8:29 PM Arunoda Susiripala notifications@github.com
wrote:

Storybook is not suppose to run this way.
This is a dev server and it has no any production level optimizations.

I suggest you to do this outside of storybook. Export your storybook as a
static site, then add basic auth when serving that.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#407 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXP8ppOzhVJFTNz9BNQhazKZ8C9EJTzks5qklIygaJpZM4Ju1JY
.

[dusterherz]

We have exactly the same needs at our work. Please considerate to reopen this PR, this is more easy to deploy than exporting the site and do all the auth after that.

[Hypnosphi]

Do you really need webpack dev-server with hot module replacement on a deployed storybook? Otherwise, what's exactly wrong with just serving static bundle?

[dusterherz]

It's not really a problem to just use the static, like i said it is just much more easier to configure Heroku with only two variables and tell him to use the dev-server than it is to generate static files and then add a server with auth. This is more to make our life easier when reviewing a teammate PR that add a component via Heroku review apps. I am aware that this is not the first use of storybook and I understand this PR has been refused for this reason.

[Hypnosphi]

You may want to try this package: https://github.com/Alex-Werner/http-server-with-auth

Alternatively, you can just copypaste the logic from this PR into your node.js file that would be responsible for serving the static

[dusterherz]

Thanks for your advice (btw, I love your hair !)