Use babelrc: false only for custom config in .storybook directory
#4077
Conversation
Hypnosphi
requested review from
alterx,
igor-dv,
leonrodenburg,
naipath,
ndelangen,
shilman,
stijnkoopal and
tmeasday
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4077 +/- ##
=======================================
Coverage 40.52% 40.52%
=======================================
Files 467 469 +2
Lines 5636 5636
Branches 747 745 -2
=======================================
Hits 2284 2284
- Misses 2982 2984 +2
+ Partials 370 368 -2
Continue to review full report at Codecov.
|
| @@ -17,27 +15,3 @@ storiesOf('Addons|Knobs/Hello', module) | |||
| age, | |||
| }); | |||
| }); | |||
|
|
|||
| storiesOf('Addons|Knobs/Hello (Marko Widget)', module) | |||
There was a problem hiding this comment.
There are no widgets in a new version?
There was a problem hiding this comment.
Looks like they decided to drop this functionality
| } | ||
|
|
||
| return babelConfig || defaultConfig; | ||
| return isBabelLoader8() ? defaultConfig : {}; |
There was a problem hiding this comment.
So, our default babel config is for babel8. After removing babelrc: false, can't we just return the default?
There was a problem hiding this comment.
Ah, just understood my mistake 🤦♂️
|
BTW, by
You mean we can get rid of |
| @@ -19,8 +19,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "marko": "^4.12.4", | |||
| "marko-starter": "^2.0.4", | |||
| "marko-widgets": "^7.0.1" | |||
There was a problem hiding this comment.
They are deprecated and don't support marko 4
No, it means that our default config is now being merged with user's |
Fixes #2582 #2771 #2610 #754 #2635
This also removes the need to duplicate our presets (react, env etc) in user's app babel config