-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start-storybook: open browser tab on first compilation #4149
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,7 +53,7 @@ | |
"postpublish": "yarn --cwd lib/cli test -o", | ||
"publish:alpha": "npm run publish -- --npm-tag=alpha", | ||
"repo-dirty-check": "node ./scripts/repo-dirty-check", | ||
"start": "npm --prefix examples/official-storybook run storybook", | ||
"start": "yarn --cwd examples/official-storybook storybook", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does this require people to have yarn installed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not really, I believe this is only applicable to the storybook project itself There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
You need it anyway when you contribute to storybook, see |
||
"test": "node ./scripts/test.js", | ||
"test-latest-cra": "npm --prefix lib/cli run test-latest-cra" | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe check for
process.env.CI
too? It's set by most CI systemsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think that
ci
is too limitingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. it would be much better to have something like
BROWSER=none start-storybook
. This is the same, that is used by cra or docusaurus.