Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with CLI rename #4407

Merged
merged 1 commit into from
Oct 13, 2018
Merged

Update docs with CLI rename #4407

merged 1 commit into from
Oct 13, 2018

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 13, 2018

Issue: #4168

What I did

Update more docs. Need to remove @alpha NPM tag as soon as we release 4.0

How to test

N/A

@@ -140,7 +140,7 @@ If you're using `start-storybook` on CI, you may need to opt out of this using t
We've deprecated the `getstorybook` CLI in 4.0. The new way to install storybook is `sb init`. We recommend using `npx` for convenience and to make sure you're always using the latest version of the CLI:

```
npx -p @storybook/cli sb init
npx -p @storybook/cli@alpha sb init
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revert this when we do the actual release

@shilman shilman changed the title Update CLI docs with rename Update docs with CLI rename Oct 13, 2018
@ndelangen ndelangen added this to the v4.0.0 milestone Oct 13, 2018
@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #4407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4407   +/-   ##
=======================================
  Coverage   36.34%   36.34%           
=======================================
  Files         557      557           
  Lines        6573     6573           
  Branches      857      857           
=======================================
  Hits         2389     2389           
  Misses       3749     3749           
  Partials      435      435

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7e549...b66c4dc. Read the comment docs.

@shilman shilman merged commit 6ef947f into master Oct 13, 2018
@shilman shilman deleted the shilman/cli-rename-in-readmes branch October 13, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants