Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @kadira/storybook-addons into resolve.alias. #462

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Add @kadira/storybook-addons into resolve.alias. #462

merged 1 commit into from
Sep 19, 2016

Conversation

arunoda
Copy link
Member

@arunoda arunoda commented Sep 19, 2016

Then addons will work on NPM2 properly.
Related issue: storybook-eol/storybook-addons#8

@arunoda
Add @kadira/storybook-addons into resolve.alias.
2e70c8e 
Then addons will work on NPM2 properly.
@arunoda arunoda merged commit 18ac324 into master Sep 19, 2016
@thani-sh thani-sh deleted the fix-addons-loading-for-npm2 branch September 19, 2016 08:43
stipsan
stipsan reviewed Sep 19, 2016
View reviewed changes
src/server/config.js
...customConfig.resolve,
alias: {
...config.alias,
...customConfig.alias,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be ...customConfig.resolve.alias?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Fixing this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a hotfix. Try now.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's resolved!

@arunoda arunoda mentioned this pull request Sep 19, 2016
Merged
@shilman shilman added the misc label May 27, 2017
@dependencies dependencies bot mentioned this pull request Sep 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stipsan stipsan stipsan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunoda @stipsan @shilman