Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Addon|Knobs|All knobs story to reflect updated addon-knobs #4954

Conversation

nickdandakis
Copy link

Issue:

Current vue-kitchen-sink example knob updates don't update the story.

What I did

Fixed 'Addon|Knobs|All knobs' story to reflect updated addon-knobs (#4773), as per my suggestion in #4947.

How to test

  • Run vue-kitchen-sink example storybook
  • Navigate to Addon|Knobs|All knobs
  • Knobs now update props of story, unlike the current vue-kitchen-sink example

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

@stale
Copy link

stale bot commented Dec 31, 2018

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 31, 2018
@ndelangen
Copy link
Member

@nickdandakis sorry for the late reply, I see some merge conflicts, can you verify this PR is still relevant?

@stale stale bot removed the inactive label Jan 3, 2019
@nickdandakis
Copy link
Author

@ndelangen, nope, this PR is no longer relevant. @backbone87 fixed the addon-knobs vue story with #5057 (specifically, this commit). Was just trying to be proactive since I came across issue #4947 and noticed the documentation was stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants