Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding /storybook.json endpoint #645

Closed
wants to merge 0 commits into from
Closed

Conversation

benzaita
Copy link

Allows enumeration of the stories and integration with tools such as BackstopJS, Gemini.

@thani-sh
Copy link
Contributor

Hi @benzaita
It's a cool idea but I think we can do this using an addon.
We recently added custom middleware support with #435

@benzaita
Copy link
Author

Thanks. I'll look into the custom middleware approach

@thani-sh
Copy link
Contributor

Awesome! let me know if you need any help :)

@benzaita
Copy link
Author

Hi @mnmtanish ,

I am afraid the compiler instance is not passed to the custom middleware - which is needed to be able to serve the up-to-date storybook object in the endpoint.

Am I missing something?

@thani-sh
Copy link
Contributor

I'll see if there's anything I can do on storybook side? or if there's some other way

@ndelangen
Copy link
Member

@benzaita I'm interested in expanding the integration-abilities, so what would you need passed to you in the middleware? which compiler?

@benzaita
Copy link
Author

@ndelangen that would be the compiler instance created by Webpack

@ndelangen
Copy link
Member

Ah! I see, I'll think about the consequences in passing that around.

@ndelangen ndelangen self-assigned this Mar 30, 2017
@ndelangen
Copy link
Member

@benzaita I'm really sorry for keeping this PR open for so long without any progress on our part.

I would be OK with merging this is if were rebased on master, would that be something you're willing to do?

@benzaita
Copy link
Author

benzaita commented Aug 2, 2017

Sure @ndelangen! Will do.

@ndelangen
Copy link
Member

Fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants