Fix/indenting for addon-notes & addon-info on markdown code blocks #7158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l be indented correctly already
ndelangen
requested review from
alexandrebodin,
dangreenisrael,
danielduan,
theinterned,
usulpro and
z4o4z
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-indenting.storybook.now.sh |
ndelangen
added
addon: info
addon: notes
bug
patch:yes
|
@martinmcwhorter would you be able to contribute a review of this change? |
ndelangen
changed the title
martinmcwhorter
approved these changes
Jun 20, 2019
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jul 31, 2019
…7158) Fix/indenting for addon-notes & addon-info on markdown code blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5574
What I did
When code examples come from markdown, they don't have the issue that the format prop is designed to solve, and so setting
format={false}solves the problem.