Upgrade all dependencies #7329
Upgrade all dependencies #7329
Conversation
ndelangen
requested review from
alexandrebodin,
CodeByAlex,
dangreenisrael,
danielduan,
igor-dv,
jbovenschen,
saponifi3d,
theinterned,
tmeasday,
usulpro and
z4o4z
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-upgrades.storybook.now.sh |
ndelangen
requested review from
alterx,
leonrodenburg,
shilman and
stijnkoopal
as code owners
|
I'm running into memory issues, I've tried:
I'd like to NOT disable source-maps, I'm investigating if:
|
|
@ndelangen also seeing memory issues on this one: #7272 |
|
@shilman do you want me to change the git history to improve the commit messages? What is your opinion on my solution for the memory issue? I was able to take it away by disabling source-maps for the official example. |
|
We discovered that it's the storysource loader, in combination with terser that's creating a memory problem. We're optimising the storysource loader to solve this problem. |
| minimizer: [ | ||
| new TerserWebpackPlugin({ | ||
| cache: false, | ||
| parallel: false, |
There was a problem hiding this comment.
yes, in the end, this should be true.
# Conflicts: # addons/knobs/src/components/Panel.tsx # addons/knobs/src/components/types/Checkboxes.js # addons/knobs/src/components/types/Files.js # addons/knobs/src/components/types/Options.js
Upgrade all dependencies
Some upgrades have caused some effects that required changes.
Some eslint rules have been improved, and I had to make some code-changes in order to linting/typescript to pass again.
I ran into a memory issue, where the terser minification would run out of memory during a static build.
It only occurs on the official storybook though.
I fixed it by setting source-maps off for this specific example. I'm not happy with this, but I have tried other solution, no other worked.