-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-select dependency to version 3 for addon-knobs #7336
Upgrade react-select dependency to version 3 for addon-knobs #7336
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-indigolain-upgradereactselectdep-9d0c59.storybook.now.sh |
3d6ce6d
to
ce09a38
Compare
Thanks @indigolain seems there are issues with the way you import
|
d4f5065
to
2ce9eb6
Compare
b2f3456
to
0967665
Compare
0967665
to
e4b2169
Compare
e4b2169
to
b611e22
Compare
@ndelangen |
Thank you for the contribution |
@ndelangen |
I invited you to the github organisation, hope to see more PRs like this 👍 |
Thank you for the invitation ❤️ |
Hah, I was just about to open a PR for this. Perfect timing 😀 |
What I did
Upgraded react-select to version 3, to keep up with emotion's new typing.
react-select version 3 upgrade guide here
Projects using addon-knobs and emotion 10, with the new css props, might encounter the issue below and needs to upgrade the react-select dependency for addon-knobs.
emotion-js/emotion#1084