Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-select dependency to version 3 for addon-knobs #7336

Conversation

indigolain
Copy link
Member

What I did

Upgraded react-select to version 3, to keep up with emotion's new typing.
react-select version 3 upgrade guide here

Projects using addon-knobs and emotion 10, with the new css props, might encounter the issue below and needs to upgrade the react-select dependency for addon-knobs.
emotion-js/emotion#1084

@vercel
Copy link

vercel bot commented Jul 8, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-indigolain-upgradereactselectdep-9d0c59.storybook.now.sh

@ndelangen
Copy link
Member

Thanks @indigolain seems there are issues with the way you import ValueType:

/Users/dev/Projects/GitHub/storybook/core/addons/knobs/src/components/types/Options.tsx
  4:27  error  Unable to resolve path to module 'react-select/lib/types'  import/no-unresolved
  4:27  error  Missing file extension for "react-select/lib/types"        import/extensions

@indigolain
Copy link
Member Author

@ndelangen
Thank you for the review! I think I've managed to fix the import issue for react-select.
Could you take a look at it?

@ndelangen ndelangen merged commit aa1d14a into storybookjs:next Jul 11, 2019
@ndelangen
Copy link
Member

Thank you for the contribution ♥️

@indigolain
Copy link
Member Author

@ndelangen
I’m glad to help 👍

@indigolain indigolain deleted the upgrade_react_select_dependency_to_version_3 branch July 11, 2019 08:40
@ndelangen
Copy link
Member

I invited you to the github organisation, hope to see more PRs like this 👍

@indigolain
Copy link
Member Author

Thank you for the invitation ❤️

@SimenB
Copy link
Contributor

SimenB commented Jul 11, 2019

Hah, I was just about to open a PR for this. Perfect timing 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants