WIP: Enable custom html in iframe <head> #77
Conversation
|
There are currently no tests or documentation for this. I just wanted a sanity check that I'm on the right path before spending too long on this. Any and all feedback on this is much appreciated! |
|
Cool, looks like a reasonable way of doing it. Just allow the user to supply their own There's probably a nicer way of doing it, but I think this would go a long way to helping 👍 |
| @@ -1,9 +1,10 @@ | |||
| export default function () { | |||
| export default function (extraHtml) { | |||
|
Yes.This is the way it should be. We don't have any tests for the server. |
karl
force-pushed
the
feature-custom-html
branch
from
3c0d46f
to
d6794d1
Compare
|
@arunoda I've added tests for the new functionality. I'm inexperienced with testing JS on the server, and wasn't sure how best to test the function. I included I'll look at adding some documentation next, although I'm not sure of the best place to put it. Any where you would prefer to add it? |
| @@ -0,0 +1,12 @@ | |||
| import path from 'path'; | |||
There was a problem hiding this comment.
Shall we move this into a file called src/server/utils.js and export the following function as getHeadHtml.
|
@karl Everything looks great. |
|
I've done the suggested I made and merged. |
|
Awesome, thanks @arunoda! |
|
Thanks you too. |
#77) * Modify number() to support a range slider as an input type for a knob. * Style changes and lint fixes. * Remove unwanted vars
…-on-configure-page Replace chevron icon on Configure page to avoid @storybook/components usage
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d6794d1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This is a work in progress to enable adding custom html to the iframe that the components are rendered in.
This is useful for loading fonts from Typekit (which require specific script tags).
The idea was brought up in this issue: #61