Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #8304 from hannah-saurusrex/mobile-styles-update #8304

Merged
merged 4 commits into from
Dec 21, 2019
Merged

Merge pull request #8304 from hannah-saurusrex/mobile-styles-update #8304

merged 4 commits into from
Dec 21, 2019

Conversation

hannah-saurusrex
Copy link
Contributor

@hannah-saurusrex hannah-saurusrex commented Oct 5, 2019 •
edited by shilman
Loading

Issue: #4896

What I did

per issue #4896, I adjusted mobile styles so that bottom bar does not obscure content.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Oct 5, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/74kjz5agh
🌍 Preview: https://monorepo-git-fork-hannah-saurusrex-mobile-styles-update.storybook.now.sh

@stale stale bot added the inactive label Oct 27, 2019
@stale stale bot closed this Nov 26, 2019
@shilman shilman reopened this Nov 26, 2019
@stale stale bot removed the inactive label Nov 26, 2019
@storybookjs storybookjs deleted a comment from stale bot Dec 2, 2019
@storybookjs storybookjs deleted a comment from stale bot Dec 2, 2019
shilman
shilman previously requested changes Dec 3, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slot turnaround on this PR -- thanks so much for putting it together! Any chance you can give it a small tweak per my comment?

examples/official-storybook/manager-head.html Outdated Show resolved Hide resolved
@shilman shilman added this to the 6.0.0 milestone Dec 20, 2019
@ndelangen ndelangen self-assigned this Dec 21, 2019
@vercel vercel bot temporarily deployed to staging December 21, 2019 12:48 Inactive
@ndelangen
Copy link
Member

Something changed so that the ul this PR was targeting changed to another element-type.

I think I found an improved fix by setting overflow: hidden on the stories container.

@ndelangen ndelangen dismissed shilman’s stale review December 21, 2019 12:50

I fixed the issue

@ndelangen ndelangen changed the base branch from next to next-6.0.0 December 21, 2019 12:50
@ndelangen ndelangen changed the title adjusted mobile styles to bottom bar did not obstruct content. Merge pull request #8304 from hannah-saurusrex/mobile-styles-update Dec 21, 2019
@ndelangen ndelangen merged commit a4622c9 into storybookjs:next-6.0.0 Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman shilman left review comments

@usulpro usulpro Awaiting requested review from usulpro

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@ndelangen ndelangen

Labels
bug ui
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hannah-saurusrex @ndelangen @shilman