[Security] Bump lodash from 4.17.11 to 4.17.15 #8351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NMinhNguyen
requested review from
aaronmcadam,
alexandrebodin,
alterx,
igor-dv,
leonrodenburg,
ndelangen,
shilman,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-nminhnguyen-lodash.storybook.now.sh |
|
@shilman there's some build failures but I'm guessing they're unrelated? Btw the motivation for this change is I was tryna onboard Storybook to our private npm registry at work, but it leverages Snyk for vulnerability scanning and it rejected my request due to |
ndelangen
approved these changes
Oct 14, 2019
ndelangen
added
the
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Oct 22, 2019
[Security] Bump lodash from 4.17.11 to 4.17.15
This was referenced Oct 30, 2019
Merged
[Snyk] Upgrade @storybook/addon-actions from 5.2.4 to 5.2.5
GrabarzUndPartner/gp-vue-boilerplate#286
Closed
Merged
Merged
This was referenced Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.npmjs.com/advisories/1065
Issue:
What I did
Updated to the latest published Lodash version. I could've just bumped to
^4.17.12as per the advisory, but figured I might as well use the latest version. Although^4.17.11does allow the installation of newer non-vulnerable versions,4.17.11satisfies that version range and seems to causeSnykto produce warnings.How to test
If your answer is yes to any of these, please make sure to include it in your PR.