Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use node types where necessary #9213

Merged
merged 2 commits into from
Dec 21, 2019

Conversation

aaronjensen
Copy link
Contributor

Fixes #8343.

What I did

Removed node from root tsconfig and added it where necessary.

How to test

  • Is this testable with Jest or Chromatic screenshots?
    No
  • Does this need a new example in the kitchen sink apps?
    No
  • Does this need an update to the documentation?
    No

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Dec 21, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/31lzpei7x
🌍 Preview: https://monorepo-git-fork-aaronjensen-limit-node-types-usage.storybook.now.sh

@vercel vercel bot requested a deployment to staging December 21, 2019 00:46 Abandoned
@vercel
Copy link

vercel bot commented Dec 21, 2019

Deployment failed with the following error:

ENOENT: no such file or directory, stat '/tmp/Gpob0Up6MVNHYIE79DkfgN1I/repo/examples/official-storybook/built-storybooks/angular-cli'

@aaronjensen
Copy link
Contributor Author

I don't know if I should be concerned by the above failures... if so, let me know and please give me a hint as to what they mean. Thanks!

@shilman shilman added this to the 6.0.0 milestone Dec 21, 2019
@ndelangen
Copy link
Member

The now deployment is a bit concerning, but I can't debug it, I'll have to run locally to debug.

@ndelangen ndelangen merged commit 1f5b228 into storybookjs:next-6.0.0 Dec 21, 2019
@aaronjensen aaronjensen deleted the limit-node-types-usage branch December 21, 2019 17:47
@aaronjensen
Copy link
Contributor Author

Thanks for the fix & the merge. I was hoping it could go into master and be a point release, but we can wait for 6.0.

@ndelangen
Copy link
Member

@shilman added it to the 6.0.0 milestone, So I'm going with that.

We can ask him if it's ok to be patched into the 5.3.x release?

@shilman
Copy link
Member

shilman commented Dec 22, 2019

I'm fine to patch after it's been out in a 6.0 alpha for a week or two.

@ndelangen
Copy link
Member

sounds good to me.

@aaronjensen
Copy link
Contributor Author

This has been out for a week or two, if it hasn't made it to 5.x is it okay for it to go there now? Thanks!

@ndelangen
Copy link
Member

@aaronjensen 5.3 will be released in a few days, then we'll start publishing alpha's of 6.0.0.

@shilman said that if this was in 6.0.0 alpha for a bit he's consider patching this change to 5.3.x

@aaronjensen
Copy link
Contributor Author

Ah, thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants