-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only use node types where necessary #9213
Only use node types where necessary #9213
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/31lzpei7x |
Deployment failed with the following error:
|
I don't know if I should be concerned by the above failures... if so, let me know and please give me a hint as to what they mean. Thanks! |
The now deployment is a bit concerning, but I can't debug it, I'll have to run locally to debug. |
5860575
to
918cfe9
Compare
Thanks for the fix & the merge. I was hoping it could go into master and be a point release, but we can wait for 6.0. |
@shilman added it to the 6.0.0 milestone, So I'm going with that. We can ask him if it's ok to be patched into the 5.3.x release? |
I'm fine to patch after it's been out in a 6.0 alpha for a week or two. |
sounds good to me. |
This has been out for a week or two, if it hasn't made it to 5.x is it okay for it to go there now? Thanks! |
@aaronjensen 5.3 will be released in a few days, then we'll start publishing alpha's of 6.0.0. @shilman said that if this was in 6.0.0 alpha for a bit he's consider patching this change to 5.3.x |
Ah, thank you for the clarification. |
Fixes #8343.
What I did
Removed node from root tsconfig and added it where necessary.
How to test
No
No
No
If your answer is yes to any of these, please make sure to include it in your PR.