Do not ignore story.js in prepublish #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing an issue with addons-info as it ends up ignoring `Story.js` during compilation. Seems there are case-similar files in other addon packages called `story.js` that were supposed to be ignored from output... However, this seems like the quickest fix that doesn't really have an impact on other packages.
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
- Coverage 26.93% 26.72% -0.22%
==========================================
Files 192 192
Lines 4384 4427 +43
Branches 705 707 +2
==========================================
+ Hits 1181 1183 +2
- Misses 3203 3244 +41
Continue to review full report at Codecov.
|
usulpro
approved these changes
Apr 28, 2017
|
@usulpro what do you think about merging PRs directly once you've tested and approved? https://github.com/storybooks/storybook/blob/master/CONTRIBUTING.md#reviewing-prs |
|
Thanks! @shilman Yes, sure! |
ndelangen
added
the
cleanup
This was referenced Jan 12, 2022
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dcfaa74. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing an issue with addons-info as it ends up ignoring
Story.jsduring compilation. Seems there are case-similar files in other addon packages calledstory.jsthat were supposed to be ignored from output... However, this seems like the quickest fix that doesn't really have an impact on other packages.Issue:
What I did
Removed
story.jsfrom the ignored babel outputHow to test
Run
npm run prepublishfromaddons-infopackage.Story.jsis not included indist/as expected.