Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue properties test WIP #9841

Closed
wants to merge 5 commits into from
Closed

Vue properties test WIP #9841

wants to merge 5 commits into from

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 13, 2020

Issue: #9838

What I did (w/ @pocka)

  1. Adapted the test setup from https://github.com/pocka/vue-docgen-loader/blob/master/test/compiler.js

Error: warn: Unhandled rejection TypeError: setTimeout(...).unref is not a function

  1. Based on TypeError: timer.unref is not a function jestjs/jest#1909 , tried creating a addons/docs/jest.config.js with:
module.exports = {
  testEnvironment: 'node',
};

But got the error:

    Could not locate module babel-runtime/core-js/get-iterator mapped as:
    core-js/es/get-iterator.

    Please check your configuration for these entries:
    {
      "moduleNameMapper": {
        "/babel-runtime\/core-js\/(.*)/": "core-js/es/$1"
      },
      "resolver": undefined
    }
  1. Based on Cannot find module 'babel-runtime/core-js/get-iterator' in Electron build miaolz123/vue-markdown#18 , tried adding babel-runtime as a devDependency. But the error persists.

How to test

Doesn't currently work:

yarn jest --testPathPattern=vue-properties.test.ts --watch

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2020

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against b5a448d

@Aaron-Pool
Copy link
Contributor

Still hoping to look at this, but I'm wrapping up a sprint at work and then I'm out of town till Saturday, so it could be a few days 😕

@Aaron-Pool
Copy link
Contributor

Aaron-Pool commented Feb 21, 2020

@shilman I finally got around to trying to dig in to this, but I'm having some troubles bootstrapping the branch in general. Does this need to be merged to master or anything? I'm definitely running latest of both node and yarn (which has been my problem in the past).

@shilman
Copy link
Member Author

shilman commented Feb 21, 2020

@Aaron-Pool I updated the branch from next and resolved conflicts. yarn bootstrap --core is working for me. Try again? Thanks!!!

@stof stof deleted the 9838-vue-properties-tests branch May 25, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: props maintenance User-facing maintenance tasks vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants