Merge pull request #464 from storybookjs/yann/fix-standalone-index-js…

…on-mode Fix: Skip requiring a main.js file in index.json mode
storybookjs · May 17, 2024 · a038ece · a038ece
2 parents 24d729f + 5ad382f
commit a038ece
Show file tree

Hide file tree

Showing 3 changed files with 1,424 additions and 2,431 deletions.
diff --git a/package.json b/package.json
@@ -80,7 +80,7 @@
     "@babel/preset-env": "^7.19.4",
     "@babel/preset-react": "^7.18.6",
     "@babel/preset-typescript": "^7.18.6",
-    "@storybook/addon-coverage": "^0.0.9",
+    "@storybook/addon-coverage": "^1.0.0",
     "@storybook/addon-essentials": "next",
     "@storybook/addon-interactions": "next",
     "@storybook/react": "next",

diff --git a/src/test-storybook.ts b/src/test-storybook.ts
@@ -362,19 +362,21 @@ const main = async () => {
     process.env.TEST_MATCH = '**/*.test.js';
   }
 
-  const { storiesPaths, lazyCompilation } = getStorybookMetadata();
-  process.env.STORYBOOK_STORIES_PATTERN = storiesPaths;
+  if (!shouldRunIndexJson) {
+    const { storiesPaths, lazyCompilation } = getStorybookMetadata();
+    process.env.STORYBOOK_STORIES_PATTERN = storiesPaths;
+
+    if (lazyCompilation && isLocalStorybookIp) {
+      log(
+        `You're running Storybook with lazy compilation enabled, and will likely cause issues with the test runner locally. Consider disabling 'lazyCompilation' in ${runnerOptions.configDir}/main.js when running 'test-storybook' locally.`
+      );
+    }
+  }
 
   if (runnerOptions.failOnConsole) {
     process.env.TEST_CHECK_CONSOLE = 'true';
   }
 
-  if (lazyCompilation && isLocalStorybookIp) {
-    log(
-      `You're running Storybook with lazy compilation enabled, and will likely cause issues with the test runner locally. Consider disabling 'lazyCompilation' in ${runnerOptions.configDir}/main.js when running 'test-storybook' locally.`
-    );
-  }
-
   await executeJestPlaywright(jestOptions);
 };