[Bug] Sync issue in failures from one test affecting another test

[yannbf]

Describe the bug

This seems not to be an actual bug in the test-runner, but rather in Storybook. Here's an example of a diagram that shows the sequence of steps in the test-runner:

Steps to reproduce the behavior

1. Change the Demo story in Button.stories.js from:

export const Demo = (args) => (
  <button type="button" onClick={() => args.onSubmit('clicked')}>
    Click
  </button>
);

to:

export const Demo = (args) => (
  <button type="button" onClick={() => { throw new Error('boom') }}>
    Click
  </button>
);

2. Run yarn test-storybook

The boom error should not leak into the FindBy story, which actually does not even use the same component as Demo:

[sneko]

@yannbf don't know if it helps but awaiting in the preRender() helped me for a "similar" issue. #244

[bryanjtc]

Removing the following code from the testPrefixer in transformPlaywright.ts fixes this issue. By removing it, the error doesn't leak to the FindBy story and it is still shown at the Demo story.

page.on('pageerror', (err) => {
          page.evaluate(({ id, err }) => __throwError(id, err), { id: %%id%%, err: err.message });
        });

It isn’t an ideal solution. Maybe I can find the cause in the jest-playwright package

[bryanjtc]

I recently updated the pr #264 to change the proposed fix for this issue.

[github-actions]

🚀 Issue was released in v0.16.0 🚀