Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync issues between tests #404

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Fix sync issues between tests #404

merged 2 commits into from
Nov 24, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 24, 2023

Closes #62

This PR introduces changes that finally fixes sync issues between failing stories. There are no leaks anymore. Thank god.

📦 Published PR as canary version: 0.15.3--canary.404.6dbd144.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.15.3--canary.404.6dbd144.0
# or 
yarn add @storybook/test-runner@0.15.3--canary.404.6dbd144.0

Version

Published prerelease version: v0.15.3-next.3

Changelog

🐛 Bug Fix

Authors: 4

@yannbf yannbf added the patch Increment the patch version when merged label Nov 24, 2023
@yannbf
Copy link
Member Author

yannbf commented Nov 24, 2023

@bryanjtc you might be interested in this!

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e6681c) 92.05% compared to head (6dbd144) 93.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #404      +/-   ##
==========================================
+ Coverage   92.05%   93.72%   +1.66%     
==========================================
  Files          15       15              
  Lines         277      271       -6     
  Branches       72       70       -2     
==========================================
- Hits          255      254       -1     
+ Misses         22       17       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yannbf yannbf merged commit 5db9536 into next Nov 24, 2023
17 checks passed
@yannbf yannbf deleted the fix/finally-fix-the-sync-issue branch November 24, 2023 15:11
@yannbf yannbf mentioned this pull request Nov 24, 2023
@bryanjtc
Copy link
Member

bryanjtc commented Nov 24, 2023

@bryanjtc you might be interested in this!

So the solution was to cleanup the error listeners after each use?
How do you came up with that solution?

Copy link

🚀 PR was released in v0.16.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Sync issue in failures from one test affecting another test
2 participants