Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document limitation for .mdx stories #102

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Document limitation for .mdx stories #102

merged 2 commits into from
Apr 28, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Apr 27, 2022

I was scratching my head for a bit as to why I was getting an error that no tests were found, when I had a .stories.mdx file that I assumed would be picked up. According to #36, --stories-json mode should be used to enable running tests against such stories.

This adds a brief note in the README about this, though it might be good to clearly document exactly which tests this does support out of the box, and point to stories.json mode for others. But, I'll admit that I'm not clear on exactly what is supported myself.

📦 Published PR as canary version: 0.0.8-canary.102.5ccece6.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.0.8-canary.102.5ccece6.0
# or 
yarn add @storybook/test-runner@0.0.8-canary.102.5ccece6.0

@IanVS IanVS requested review from shilman and yannbf April 27, 2022 19:23
@IanVS
Copy link
Member Author

IanVS commented Apr 27, 2022

Oops, I need to remove .svelte from this, they don't work with buildStoriesJson. storybookjs/storybook#18081

@IanVS IanVS changed the title Document limitation for .mdx and .svelte stories Document limitation for .mdx stories Apr 28, 2022
@yannbf yannbf added the documentation Changes only affect the documentation label Apr 28, 2022
@yannbf
Copy link
Member

yannbf commented Apr 28, 2022

Thanks for your contribution @IanVS !

@yannbf yannbf merged commit b17bb51 into next Apr 28, 2022
@yannbf yannbf mentioned this pull request Apr 28, 2022
@yannbf yannbf deleted the mdx-warning branch November 18, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants