-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code coverage for coverage merging #130
Conversation
1f600a1
to
498cc05
Compare
498cc05
to
d206bb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. So, to confirm, json reports can be merged across directories? From our earlier conversation I was under the impression that the two json files needed to be in the same directory.
They are extracted automatically by tools like Codecov. Tools like |
This PR:
coverage/storybook/coverage-storybook.json
file after running with--coverage
If people use tools like Codecov and generate multiple coverage reports (e.g. Jest + Storybook), Codecov will detect them automatically and merge them. For people who want to make a full coverage map locally, they will have to do a bit of scripting:
coverage/storybook/coverage-storybook.json
tocoverage/coverage-storybook.json
npx nyc report --reporter=lcov -t coverage --report-dir coverage
📦 Published PR as canary version:
0.2.1--canary.130.4d54d5b.0
✨ Test out this PR locally via:
npm install @storybook/test-runner@0.2.1--canary.130.4d54d5b.0 # or yarn add @storybook/test-runner@0.2.1--canary.130.4d54d5b.0
Version
Published prerelease version:
v0.3.0-next.1
Changelog
Release Notes
Support code coverage (#120)
Support code coverage (#120)
🚀 Enhancement
🐛 Bug Fix
Authors: 1