-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document need for a custom snapshotResolver #131
Conversation
Hey @FokkeZB thanks for your contribution! That should not be a problem unless you're using |
@yannbf I will. Although I must say I haven't been able to get the test runner to work without
And that's it 🤷 |
That's odd! Can you reach out on twitter? |
See #133 for the bug that causes |
@yannbf I've updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks a lot for your contribution @FokkeZB !
🚀 PR was released in |
I noticed that (DOM) snapshots get stored alongside with the generated tests, and since they get generated in a temporary folder, that doesn't work.
Fortunately Jest supports a custom
snapshotResolver
, so I updated the README with instructions on how to use that.