-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Storybook 7.0 play function exceptions #190
Support Storybook 7.0 play function exceptions #190
Conversation
@yannbf, nope this should do it. There are two things that can happen from the SB side:
Either way as long as we listen to both events we should be fine. The breaking change here is in case 2. where the |
Got it! I'll take a look at it tomorrow and check regarding the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tmeasday !!
hidePlayFunctionExceptions
set
This test is already automated via the nightly check! |
🚀 PR was released in |
See storybookjs/storybook#19143
We need to ensure that stories that do not emit an
STORY_THREW_EXCEPTION
on play function error are still handled. (SBs withhidePlayFunctionExceptions
set)To test:
./bin/test-storybook.js --url http://localhost:6006 -i example-button.test.js
@yannbf I'm not how to automate the above testing, perhaps you can give some guidance, if it's possible?
📦 Published PR as canary version:
0.7.2--canary.190.e69606f.0
✨ Test out this PR locally via:
npm install @storybook/test-runner@0.7.2--canary.190.e69606f.0 # or yarn add @storybook/test-runner@0.7.2--canary.190.e69606f.0
Version
Published prerelease version:
v0.7.2-next.0
Changelog
🐛 Bug Fix
Authors: 3