Improve error logging and ensure non-zero exit #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
approved these changes
Oct 11, 2022
This was referenced Oct 12, 2022
Merged
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting an error when running the test-runner, but it did not fail CI because an exit code of
0was being returned. Also, the error message did not have any stack trace or other information, so it was nearly impossible to tell why it was failing.This PR adds a stacktrace to the error message returned, and ensures that we exit with a non-zero code, so that CI fails correctly. I also made the title red, just because I think it helps a little for clarity.
Before:
After:
Underlying issue causing this error: #200
Oh, and I fixed some import paths. I think the actual imports were working before, but typescript couldn't find them, I guess due to the way that the compiled babel output converted
export * from.
# VersionPublished prerelease version:
v0.8.1-next.0Changelog
🐛 Bug Fix
Authors: 1