Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove last reference to regenerator-runtime #303

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

bryanjtc
Copy link
Member

@bryanjtc bryanjtc commented May 8, 2023

There was one line of code still referencing regenerator-runtime. It's no longer used.
Fixes: #304

📦 Published PR as canary version: 0.10.1--canary.303.86f873e.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.10.1--canary.303.86f873e.0
# or 
yarn add @storybook/test-runner@0.10.1--canary.303.86f873e.0

Version

Published prerelease version: v0.11.0-future.2

Changelog

🚀 Enhancement

🐛 Bug Fix

  • fix: Remove last reference to regenerator-runtime #303 (@bryanjtc)
  • fix(test-storybook): Fix test-runner-jest.config.js file not being found in STORYBOOK_CONFIG_DIR on Windows #296 (@unshame)
  • Upgrade glob to v10 #299 (@valentinpalkovic)
  • update dependencies to future (@yannbf)

Authors: 5

@bryanjtc bryanjtc changed the title Remove last reference to regenerator-runtime fix: Remove last reference to regenerator-runtime May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1cc46df) 76.63% compared to head (86f873e) 76.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           future     #303   +/-   ##
=======================================
  Coverage   76.63%   76.63%           
=======================================
  Files          11       11           
  Lines         184      184           
  Branches       39       39           
=======================================
  Hits          141      141           
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yannbf yannbf added patch Increment the patch version when merged pick This should be cherry-picked to the main branch labels Jun 5, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@github-actions
Copy link

🚀 PR was released in v0.11.0 🚀

@bryanjtc bryanjtc deleted the cleanup-reference branch July 14, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged pick This should be cherry-picked to the main branch released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] regenerator-runtime removed as a dependency but required in custom-environment.js
2 participants