Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Update to yarn berry #344

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Maintenance: Update to yarn berry #344

merged 1 commit into from
Aug 27, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 27, 2023

No description provided.

@yannbf yannbf added the skip-release Preserve the current version when merged label Aug 27, 2023
@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Bin script confusion storybook 7.3.1
  • Bin Script: sb
Bin script confusion storybook 7.3.2
  • Bin Script: sb
New author istanbul-lib-report 3.0.1
New author handlebars 4.7.8
New author nopt 6.0.0
Shell access node-gyp 9.4.0

Next steps

What is bin script confusion?

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore istanbul-lib-report@3.0.1
  • @SocketSecurity ignore handlebars@4.7.8
  • @SocketSecurity ignore nopt@6.0.0
  • @SocketSecurity ignore node-gyp@9.4.0
  • @SocketSecurity ignore storybook@7.3.1
  • @SocketSecurity ignore storybook@7.3.2

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (01f49f5) 76.66% compared to head (d73dfe6) 76.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #344   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files          11       11           
  Lines         180      180           
  Branches       40       40           
=======================================
  Hits          138      138           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yannbf yannbf merged commit 9e1136e into next Aug 27, 2023
13 of 14 checks passed
@yannbf yannbf deleted the yann/update-to-yarn-berry branch August 27, 2023 10:04
@legobeat
Copy link
Contributor

legobeat commented Sep 3, 2023

The lockfile and resulting node_modules are larger than they need to be. #347

Copy link

github-actions bot commented Nov 8, 2023

🚀 PR was released in v0.14.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants