Add setPreRender/setPostRender hooks & example

README.md

@@ -14,6 +14,7 @@ Storybook test runner turns all of your stories into executable tests.
   - [Running in CI](#running-in-ci)
     - [1. Running against deployed Storybooks on Github Actions deployment](#1-running-against-deployed-storybooks-on-github-actions-deployment)
     - [2. Running against locally built Storybooks in CI](#2-running-against-locally-built-storybooks-in-ci)
+  - [Experimental test hook API](#experimental-test-hook-api)
   - [Troubleshooting](#troubleshooting)
     - [The test runner seems flaky and keeps timing out](#the-test-runner-seems-flaky-and-keeps-timing-out)
     - [Adding the test runner to other CI environments](#adding-the-test-runner-to-other-ci-environments)
@@ -228,6 +229,55 @@ jobs:
 
 > **_NOTE:_** Building Storybook locally makes it simple to test Storybooks that could be available remotely, but are under authentication layers. If you also deploy your Storybooks somewhere (e.g. Chromatic, Vercel, etc.), the Storybook URL can still be useful with the test-runner. You can pass it to the `REFERENCE_URL` environment variable when running the test-storybook command, and if a story fails, the test-runner will provide a helpful message with the link to the story in your published Storybook instead.
 
+## Experimental test hook API
+
+The test runner renders a story and executes its [play function](https://storybook.js.org/docs/react/writing-stories/play-function) if one exists. However, there are certain behaviors that are not possible to achieve via the play function, which executes in the browser. For example, if you want the test runner to take visual snapshots for you, this is something that is possible via Playwright/Jest, but must be executed in Node.
+
+To enable use cases like visual or DOM snapshots, the test runner exports test hooks that can be overridden globally. These hooks give you access to the test lifecycle before and after the story is rendered.
+
+Consider the following pseudocode:
+
+```js
+it('component--widget', async () => {
+  const page = newPage();
+  const context = { id: 'component--widget', title: 'Component', name: 'Widget' };
+  await page.goto(STORYBOOK_URL);
+
+  // pre-render hook
+  if (preRender) await preRender(page, context);
+
+  // render the story and run its paly function (if applicable)
+  await page.execute('render', context);
+
+  // post-render hook
+  if (postRender) await postRender(page, context);
+});
+```
+
+The hooks here, `preRender` and `postRender` are functions that take a [Playwright Page](https://playwright.dev/docs/pages) and a context object with the current story `id`, `title`, and `name`. They are globally settable by `@storybook/test-runner`'s `setPreRender` and `setPostRender` APIs.
+
+Thus, to make the test runner perform image snapshotting, you might set up the following in your `jest-setup.js`:
+
+```js
+const { toMatchImageSnapshot } = require('jest-image-snapshot');
+const { setPostRender } = require('@storybook/test-runner');
+
+expect.extend({ toMatchImageSnapshot });
+
+// use custom directory/id to align CSF and stories.json mode outputs
+const customSnapshotsDir = `${process.cwd()}/__snapshots__`;
+
+setPostRender(async (page, context) => {
+  const image = await page.screenshot();
+  expect(image).toMatchImageSnapshot({
+    customSnapshotsDir,
+    customSnapshotIdentifier: context.id,
+  });
+});
+```
+
+> **NOTE:** These test hooks are experimental and may be subject to breaking changes. We encourage you to test as much as possible within the story's play function when that's possible.
+
 ## Troubleshooting
 
 #### The test runner seems flaky and keeps timing out

jest-setup.js

@@ -0,0 +1,15 @@
+const { toMatchImageSnapshot } = require('jest-image-snapshot');
+const { setPostRender } = require('./dist/cjs');
+
+expect.extend({ toMatchImageSnapshot });
+
+// use custom directory/id to align CSF and stories.json mode outputs
+const customSnapshotsDir = `${process.cwd()}/__snapshots__`;
+
+setPostRender(async (page, context) => {
+  const image = await page.screenshot();
+  expect(image).toMatchImageSnapshot({
+    customSnapshotsDir,
+    customSnapshotIdentifier: context.id,
+  });
+});

package.json

@@ -82,6 +82,7 @@
     "dedent": "^0.7.0",
     "jest": "^27.0.6",
     "jest-environment-jsdom": "^27.0.6",
+    "jest-image-snapshot": "^4.5.1",
     "prettier": "^2.3.1",
     "prop-types": "^15.7.2",
     "react": "^17.0.1",
@@ -105,6 +106,7 @@
   "dependencies": {
     "@storybook/csf": "0.0.2--canary.87bc651.0",
     "@storybook/csf-tools": "^6.4.14",
+    "global": "^4.4.0",
     "jest-playwright-preset": "^1.7.0",
     "node-fetch": "^2",
     "playwright": "^1.14.0",

src/csf/transformCsf.ts

@@ -14,8 +14,9 @@ export interface TestContext {
   id: t.Literal;
   hasPlayFn?: t.BooleanLiteral;
 }
-type FilePrefixer = () => t.Statement[];
-type TestPrefixer = (context: TestContext) => t.Statement[];
+type TemplateResult = t.Statement | t.Statement[];
+type FilePrefixer = () => TemplateResult;
+type TestPrefixer = (context: TestContext) => TemplateResult;
 
 interface TransformOptions {
   clearBody?: boolean;
@@ -41,7 +42,7 @@ const prefixFunction = (
   };
 
   // instead, let's just make the prefixer return the function
-  const result = testPrefixer(context);
+  const result = makeArray(testPrefixer(context));
   const stmt = result[1] as t.ExpressionStatement;
   return stmt.expression;
 };
@@ -71,6 +72,9 @@ const makeDescribe = (key: string, tests: t.Statement[]): t.Statement | null =>
   );
 };
 
+const makeArray = (templateResult: TemplateResult) =>
+  Array.isArray(templateResult) ? templateResult : [templateResult];
+
 export const transformCsf = (
   code: string,
   {
@@ -112,7 +116,7 @@ export const transformCsf = (
 
   // FIXME: insert between imports
   if (filePrefixer) {
-    const { code: prefixCode } = generate(t.program(filePrefixer()), {});
+    const { code: prefixCode } = generate(t.program(makeArray(filePrefixer())), {});
     result = `${prefixCode}\n`;
   }
   if (!clearBody) result = `${result}${code}\n`;

src/index.ts

@@ -0,0 +1 @@
+export * from './playwright/hooks';

src/playwright/hooks.ts

@@ -0,0 +1,18 @@
+import global from 'global';
+import type { Page } from 'playwright';
+
+export type TestContext = {
+  id: string;
+  title: string;
+  name: string;
+};
+
+export type TestHook = (page: Page, context: TestContext) => Promise<void>;
+
+export const setPreRender = (preRender: TestHook) => {
+  global.__sbPreRender = preRender;
+};
+
+export const setPostRender = (postRender: TestHook) => {
+  global.__sbPostRender = postRender;
+};

src/playwright/transformPlaywright.test.ts

@@ -46,10 +46,17 @@ describe('Playwright', () => {
         filename
       )
     ).toMatchInlineSnapshot(`
+      import global from 'global';
+
       if (!require.main) {
         describe("foo/bar", () => {
         describe("A", () => {
           it("play-test", async () => {
+            const context = {
+              id: "foo-bar--a",
+              title: "foo/bar",
+              name: "A"
+            };
             page.on('pageerror', err => {
               page.evaluate(({
                 id,
@@ -59,13 +66,24 @@ describe('Playwright', () => {
                 err: err.message
               });
             });
-            return page.evaluate(({
+
+            if (global.__sbPreRender) {
+              await global.__sbPreRender(page, context);
+            }
+
+            const result = await page.evaluate(({
               id,
               hasPlayFn
             }) => __test(id, hasPlayFn), {
               id: "foo-bar--a",
               hasPlayFn: true
             });
+
+            if (global.__sbPostRender) {
+              await global.__sbPostRender(page, context);
+            }
+
+            return result;
           });
         });
       });
@@ -82,10 +100,17 @@ describe('Playwright', () => {
         filename
       )
     ).toMatchInlineSnapshot(`
+      import global from 'global';
+
       if (!require.main) {
         describe("foo/bar", () => {
         describe("A", () => {
           it("smoke-test", async () => {
+            const context = {
+              id: "foo-bar--a",
+              title: "foo/bar",
+              name: "A"
+            };
             page.on('pageerror', err => {
               page.evaluate(({
                 id,
@@ -95,13 +120,24 @@ describe('Playwright', () => {
                 err: err.message
               });
             });
-            return page.evaluate(({
+
+            if (global.__sbPreRender) {
+              await global.__sbPreRender(page, context);
+            }
+
+            const result = await page.evaluate(({
               id,
               hasPlayFn
             }) => __test(id, hasPlayFn), {
               id: "foo-bar--a",
               hasPlayFn: false
             });
+
+            if (global.__sbPostRender) {
+              await global.__sbPostRender(page, context);
+            }
+
+            return result;
           });
         });
       });
@@ -119,10 +155,17 @@ describe('Playwright', () => {
         filename
       )
     ).toMatchInlineSnapshot(`
+      import global from 'global';
+
       if (!require.main) {
         describe("Example/Header", () => {
         describe("A", () => {
           it("smoke-test", async () => {
+            const context = {
+              id: "example-header--a",
+              title: "Example/Header",
+              name: "A"
+            };
             page.on('pageerror', err => {
               page.evaluate(({
                 id,
@@ -132,13 +175,24 @@ describe('Playwright', () => {
                 err: err.message
               });
             });
-            return page.evaluate(({
+
+            if (global.__sbPreRender) {
+              await global.__sbPreRender(page, context);
+            }
+
+            const result = await page.evaluate(({
               id,
               hasPlayFn
             }) => __test(id, hasPlayFn), {
               id: "example-header--a",
               hasPlayFn: false
             });
+
+            if (global.__sbPostRender) {
+              await global.__sbPostRender(page, context);
+            }
+
+            return result;
           });
         });
       });

src/playwright/transformPlaywright.ts

@@ -5,18 +5,34 @@ import { autoTitle } from '@storybook/store';
 
 import { transformCsf } from '../csf/transformCsf';
 
+const filePrefixer = template(`
+  import global from 'global';
+`);
+
 export const testPrefixer = template(
   `
     console.log({ id: %%id%%, title: %%title%%, name: %%name%%, storyExport: %%storyExport%% });
     async () => {
+      const context = { id: %%id%%, title: %%title%%, name: %%name%% };
+
       page.on('pageerror', (err) => {
         page.evaluate(({ id, err }) => __throwError(id, err), { id: %%id%%, err: err.message });
       });
 
-      return page.evaluate(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
+      if(global.__sbPreRender) {
+        await global.__sbPreRender(page, context);
+      }
+
+      const result = await page.evaluate(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
         id: %%id%%,
         hasPlayFn: %%hasPlayFn%%,
       });
+
+      if(global.__sbPostRender) {
+        await global.__sbPostRender(page, context);
+      }
+
+      return result;
     }
   `,
   {
@@ -52,6 +68,7 @@ const getDefaultTitle = (filename: string) => {
 export const transformPlaywright = (src: string, filename: string) => {
   const defaultTitle = getDefaultTitle(filename);
   const result = transformCsf(src, {
+    filePrefixer,
     // @ts-ignore
     testPrefixer,
     insertTestIfEmpty: true,