Add CLI wrapper #41
Merged
Add CLI wrapper #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
force-pushed
the
feat/cli-wrapper
branch
from
b107dd0
to
20840c8
Compare
shilman
requested changes
Feb 3, 2022
| @@ -1,10 +1,12 @@ | |||
| import dedent from 'ts-dedent'; | |||
| import path from 'path'; | |||
| import * as coreCommon from '@storybook/core-common'; | |||
| import * as cli from '../util/cli'; | |||
|
|
|||
| import { transformPlaywright } from './transformPlaywright'; | |||
|
|
|||
| jest.mock('@storybook/core-common'); | |||
There was a problem hiding this comment.
Yes, because of the jest.spyOn(coreCommon, 'normalizeStories') code below
shilman
reviewed
Feb 3, 2022
yannbf
force-pushed
the
feat/cli-wrapper
branch
from
20840c8
to
9b77c29
Compare
shilman
approved these changes
Feb 3, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: SB-20
What I did
This PR adds a CLI wrapper with the following commands:
It will retain test runner configs and pass the rest to jest-playwright. If users end up trying a flag that is not supported, they will get an error message with a link to open an issue on this repo:
📦 Published PR as canary version:
0.0.2-canary.41.9b77c29.0✨ Test out this PR locally via:
npm install @storybook/test-runner@0.0.2-canary.41.9b77c29.0 # or yarn add @storybook/test-runner@0.0.2-canary.41.9b77c29.0Version
Published prerelease version:
v0.0.2-next.6Changelog
🐛 Bug Fix
next📝 Documentation
Authors: 2