Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace postRender(deprecated) with postVisit #418

Merged
merged 1 commit into from
Dec 22, 2023
Merged

docs: replace postRender(deprecated) with postVisit #418

merged 1 commit into from
Dec 22, 2023

Conversation

junkisai
Copy link
Contributor

In issue #394, postRender was renamed to postVisit, and the use of postRender was deprecated.
However, there were still some parts in the README where postRender was being used.

In this PR, postRender has been replaced with postVisit to avoid using the deprecated function in implementation samples.

yannbf
yannbf approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @junkisai ! <3

@yannbf yannbf added documentation Changes only affect the documentation skip-release Preserve the current version when merged labels Dec 22, 2023
@yannbf yannbf merged commit 214c9f4 into storybookjs:next Dec 22, 2023
8 checks passed
@junkisai junkisai deleted the docs/not-recommended-deprecated-func branch December 23, 2023 18:14
@rhannachi rhannachi mentioned this pull request May 31, 2024
Open
@rhannachi rhannachi mentioned this pull request Jun 8, 2024
Open
@rhannachi rhannachi mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen kasperpeulen is a code owner

Assignees
No one assigned
Labels
documentation Changes only affect the documentation prerelease skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junkisai @yannbf