-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update internal example to Storybook 8 #430
Conversation
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an invalid package.json?Package has an invalid package.json and can cause installation problems if you try to use it. Fix syntax errors in the invalid package.json and publish a new version with a valid package.json. Consumers can use npm overrides to force a version that does not have this problem if one exists. What is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #430 +/- ##
==========================================
+ Coverage 93.77% 93.81% +0.04%
==========================================
Files 15 15
Lines 273 275 +2
Branches 71 71
==========================================
+ Hits 256 258 +2
Misses 17 17 ☔ View full report in Codecov by Sentry. |
🚀 PR was released in |
Closes #
What I did
The internal examples now use Storybook 8 and CSF 3
Checklist for Contributors
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
Checklist for Maintainers
Make sure this PR contains one of the labels below:
Available labels
skip-release
: Skip any releases, e.g., documentation only changes, CI config etc.patch
: Upgrade patch version (e.g. 0.0.x)minor
: Upgrade patch version (e.g. 0.x.0)major
: Upgrade patch version (e.g. x.0.0)