Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal example to Storybook 8 #430

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 24, 2024

Closes #

What I did

The internal examples now use Storybook 8 and CSF 3

Checklist for Contributors

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes in this repository
  • Request documentation updates in the test-runner docs website

Checklist for Maintainers

  • Make sure this PR contains one of the labels below:

    Available labels
    • skip-release: Skip any releases, e.g., documentation only changes, CI config etc.
    • patch: Upgrade patch version (e.g. 0.0.x)
    • minor: Upgrade patch version (e.g. 0.x.0)
    • major: Upgrade patch version (e.g. x.0.0)

@yannbf yannbf added the skip-release Preserve the current version when merged label Jan 24, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@mdx-js/react@3.0.0 Transitive: environment +9 1.97 MB wooorm
npm/@storybook/addon-actions@8.0.0-alpha.14 Transitive: environment +9 3.86 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-backgrounds@8.0.0-alpha.14 Transitive: environment +11 4.69 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-controls@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +279 250 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-docs@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +325 262 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-essentials@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +336 263 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-highlight@8.0.0-alpha.14 None +1 12.4 kB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/addon-interactions@8.0.0-alpha.14 Transitive: environment, eval, filesystem +58 18.1 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/addon-measure@8.0.0-alpha.14 Transitive: environment +9 4.62 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/addon-outline@8.0.0-alpha.14 Transitive: environment +9 4.63 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/addon-toolbars@8.0.0-alpha.14 None 0 9.96 kB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-viewport@8.0.0-alpha.14 Transitive: environment +2 82 kB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/blocks@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +278 250 MB alexandrebodin, amalik2, dandean, ...26 more
npm/@storybook/builder-manager@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +303 239 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/builder-vite@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +307 308 MB
npm/@storybook/cli@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +591 280 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/codemod@8.0.0-alpha.14 Transitive: environment, eval, filesystem, shell, unsafe +298 35.3 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/components@8.0.0-alpha.14 Transitive: environment, eval, filesystem +60 16.4 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/core-server@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +369 256 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/csf-plugin@8.0.0-alpha.14 Transitive: environment, eval, filesystem +99 15.3 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/docs-mdx@3.0.0 None 0 9.18 MB shilman
npm/@storybook/docs-tools@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +252 235 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/icons@1.2.3 Transitive: environment +6 4.58 MB ndelangen
npm/@storybook/instrumenter@8.0.0-alpha.14 Transitive: environment, eval, filesystem +59 7.17 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/manager-api@8.0.0-alpha.14 Transitive: environment, eval, filesystem +53 10.8 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/manager@8.0.0-alpha.14 None 0 2.29 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/preview@8.0.0-alpha.14 None 0 334 kB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/react-dom-shim@8.0.0-alpha.14 Transitive: environment +6 3.46 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/react-vite@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +377 319 MB
npm/@storybook/react@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +274 307 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/router@8.0.0-alpha.14 Transitive: environment, eval +17 711 kB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/telemetry@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +269 235 MB alexandrebodin, amalik2, dandean, ...23 more
npm/@storybook/test@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +409 503 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/theming@8.0.0-alpha.14 Transitive: environment +11 4.24 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@types/hast@3.0.3 None +1 16 kB types
npm/@types/unist@3.0.2 None 0 6.28 kB types
npm/@ungap/structured-clone@1.2.0 None 0 26.2 kB webreflection
npm/@vitest/expect@1.1.3 None +13 1.29 MB oreanno
npm/@vitest/spy@1.2.1 None +1 31.6 kB oreanno
npm/agent-base@6.0.2 Transitive: environment +2 49.2 kB tootallnate
npm/github-slugger@2.0.0 None 0 15.9 kB wooorm
npm/hast-util-heading-rank@3.0.0 None +2 25.1 kB wooorm
npm/hast-util-is-element@3.0.0 None +2 42.3 kB wooorm
npm/hast-util-to-string@3.0.0 None +2 24.5 kB wooorm
npm/is-absolute-url@4.0.1 None 0 3.52 kB sindresorhus
npm/markdown-to-jsx@7.3.2 Transitive: environment +4 727 kB probablyup
npm/rehype-external-links@3.0.0 None +9 192 kB wooorm
npm/rehype-slug@6.0.0 None +8 150 kB wooorm
npm/scheduler@0.23.0 environment +2 114 kB gnoff
npm/space-separated-tokens@2.0.2 None 0 7.75 kB wooorm
npm/storybook@8.0.0-alpha.14 Transitive: environment, eval, filesystem, network, shell, unsafe +592 280 MB
npm/unist-util-is@6.0.0 None +1 33.4 kB wooorm
npm/unist-util-visit-parents@6.0.1 None +2 66.3 kB wooorm
npm/unist-util-visit@5.0.0 None +3 94.8 kB wooorm

🚮 Removed packages: npm/@babel/plugin-proposal-class-properties@7.18.6, npm/@babel/plugin-proposal-nullish-coalescing-operator@7.18.6, npm/@babel/plugin-proposal-optional-chaining@7.21.0, npm/@floating-ui/core@1.5.3, npm/@floating-ui/dom@1.5.4, npm/@floating-ui/react-dom@2.0.6, npm/@floating-ui/utils@0.2.1, npm/@juggle/resize-observer@3.4.0, npm/@mdx-js/react@2.3.0, npm/@radix-ui/number@1.0.1, npm/@radix-ui/primitive@1.0.1, npm/@radix-ui/react-arrow@1.0.3, npm/@radix-ui/react-collection@1.0.3, npm/@radix-ui/react-context@1.0.1, npm/@radix-ui/react-direction@1.0.1, npm/@radix-ui/react-dismissable-layer@1.0.4, npm/@radix-ui/react-focus-guards@1.0.1, npm/@radix-ui/react-focus-scope@1.0.3, npm/@radix-ui/react-id@1.0.1, npm/@radix-ui/react-popper@1.1.2, npm/@radix-ui/react-portal@1.0.3, npm/@radix-ui/react-primitive@1.0.3, npm/@radix-ui/react-roving-focus@1.0.4, npm/@radix-ui/react-select@1.2.2, npm/@radix-ui/react-separator@1.0.3, npm/@radix-ui/react-toggle-group@1.0.4, npm/@radix-ui/react-toggle@1.0.3, npm/@radix-ui/react-toolbar@1.0.4, npm/@radix-ui/react-use-callback-ref@1.0.1, npm/@radix-ui/react-use-controllable-state@1.0.1, npm/@radix-ui/react-use-escape-keydown@1.0.3, npm/@radix-ui/react-use-layout-effect@1.0.1, npm/@radix-ui/react-use-previous@1.0.1, npm/@radix-ui/react-use-rect@1.0.1, npm/@radix-ui/react-use-size@1.0.1, npm/@radix-ui/react-visually-hidden@1.0.3, npm/@radix-ui/rect@1.0.1, npm/@storybook/addon-actions@7.6.10, npm/@storybook/addon-backgrounds@7.6.10, npm/@storybook/addon-controls@7.6.10, npm/@storybook/addon-docs@7.6.10, npm/@storybook/addon-essentials@7.6.10, npm/@storybook/addon-highlight@7.6.10, npm/@storybook/addon-interactions@7.6.10, npm/@storybook/addon-measure@7.6.10, npm/@storybook/addon-outline@7.6.10, npm/@storybook/addon-toolbars@7.6.10, npm/@storybook/addon-viewport@7.6.10, npm/@storybook/blocks@7.6.10, npm/@storybook/builder-manager@7.6.10, npm/@storybook/builder-vite@7.6.10, npm/@storybook/channels@7.6.10, npm/@storybook/cli@7.6.10, npm/@storybook/client-logger@7.6.10, npm/@storybook/codemod@7.6.10, npm/@storybook/components@7.6.10, npm/@storybook/core-client@7.6.10, npm/@storybook/core-events@7.6.10, npm/@storybook/core-server@7.6.10, npm/@storybook/csf-plugin@7.6.10, npm/@storybook/docs-mdx@0.1.0, npm/@storybook/docs-tools@7.6.10, npm/@storybook/instrumenter@7.6.10, npm/@storybook/manager-api@7.6.10, npm/@storybook/manager@7.6.10, npm/@storybook/mdx2-csf@1.1.0, npm/@storybook/node-logger@7.6.10, npm/@storybook/postinstall@7.6.10, npm/@storybook/preview@7.6.10, npm/@storybook/react-dom-shim@7.6.10, npm/@storybook/react-vite@7.6.10, npm/@storybook/react@7.6.10, npm/@storybook/router@7.6.10, npm/@storybook/telemetry@7.6.10, npm/@storybook/test@7.6.10, npm/@storybook/theming@7.6.10, npm/@storybook/types@7.6.10, npm/@types/chai@4.3.11, npm/@types/mime-types@2.1.4, npm/@types/unist@2.0.10, npm/@vitest/expect@0.34.7, npm/@vitest/spy@0.34.7, npm/aria-hidden@1.2.3, npm/async-limiter@1.0.1, npm/buffer-crc32@0.2.13, npm/concat-stream@1.6.2, npm/detect-node-es@1.1.0, npm/extend@3.0.2, npm/extract-zip@1.7.0, npm/fd-slicer@1.1.0, npm/get-nonce@1.0.1, npm/get-port@5.1.1, npm/github-slugger@1.5.0, npm/invariant@2.2.4, npm/is-absolute-url@3.0.3, npm/markdown-to-jsx@7.4.0, npm/mdast-util-definitions@4.0.0, npm/mdast-util-to-string@1.1.0, npm/pend@1.2.0, npm/progress@2.0.3, npm/puppeteer-core@2.1.1, npm/react-inspector@6.0.2, npm/react-remove-scroll-bar@2.3.4, npm/react-remove-scroll@2.5.5, npm/react-style-singleton@2.2.1, npm/remark-external-links@8.0.0, npm/remark-slug@6.1.0, npm/simple-update-notifier@2.0.0, npm/space-separated-tokens@1.1.5, npm/storybook@7.6.10, npm/synchronous-promise@2.0.17, npm/typedarray@0.0.6, npm/unist-util-is@4.1.0, npm/unist-util-visit-parents@3.1.1, npm/unist-util-visit@2.0.3, npm/use-callback-ref@1.3.1, npm/use-resize-observer@9.1.0, npm/use-sidecar@1.1.2, npm/yauzl@2.10.0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Invalid package.json npm/agent-base@6.0.2
New author npm/react@18.2.0
New author npm/react-dom@18.2.0
New author npm/scheduler@0.23.0

View full report↗︎

Next steps

What is an invalid package.json?

Package has an invalid package.json and can cause installation problems if you try to use it.

Fix syntax errors in the invalid package.json and publish a new version with a valid package.json. Consumers can use npm overrides to force a version that does not have this problem if one exists.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/agent-base@6.0.2
  • @SocketSecurity ignore npm/react@18.2.0
  • @SocketSecurity ignore npm/react-dom@18.2.0
  • @SocketSecurity ignore npm/scheduler@0.23.0

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b22464) 93.77% compared to head (ad09521) 93.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #430      +/-   ##
==========================================
+ Coverage   93.77%   93.81%   +0.04%     
==========================================
  Files          15       15              
  Lines         273      275       +2     
  Branches       71       71              
==========================================
+ Hits          256      258       +2     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yannbf yannbf merged commit a3c9fb6 into next Jan 24, 2024
18 of 19 checks passed
@yannbf yannbf deleted the yann/update-example-to-sb-8 branch January 24, 2024 10:41
Copy link

🚀 PR was released in v0.17.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant