Make waitFor interceptable and don't override interval/timeout

[ghengeveld]

Works in tandem with storybookjs/storybook#18460

Change Type

Indicate the type of change your pull request is:

• maintenance
• documentation
• patch
• minor
• major

📦 Published PR as canary version: 0.0.14--canary.23.51ebb1b.0

✨ Test out this PR locally via:

npm install @storybook/testing-library@0.0.14--canary.23.51ebb1b.0
# or 
yarn add @storybook/testing-library@0.0.14--canary.23.51ebb1b.0

Version

Published prerelease version: v0.0.14-next.1

Changelog

🐛 Bug Fix

• Make waitFor interceptable and don't override interval/timeout #23 (@ghengeveld @yannbf)
• support storybook 7.0 #30 (@yannbf)

Authors: 2

• Gert Hengeveld (@ghengeveld)
• Yann Braga (@yannbf)

[yannbf]

Great stuff @ghengeveld ! What does this mean for users that might be in a scenario with Storybook 6.4 and the new version of this package?

[yannbf]

Nevermind I got the answer. For Storybook 6.4 users using this fix:

For situations where steps pass, it will surface waitFor, which is nice:

---

But in a failure scenario, there is a big difference:

Before:

After:

[IanVS]

Is it possible that this will fix #9? And maybe even #8, or is that too optimistic of me?

[ghengeveld]

Is it possible that this will fix #9? And maybe even #8, or is that too optimistic of me?

There's a good chance this will address #9 because we've gotten rid of "forwardedExceptions" which sometimes led to weird behavior. Give it a try!

For #8 at the very least this will log any exception before throwing the ignoredException, so you'll be able to see the original error in the browser console. I'll also revisit storybookjs/storybook#16592 which is related.

[IanVS]

Hi, I'm excited for this change, is it waiting for something, or maybe it can be merged?

[yannbf]

Hi, I'm excited for this change, is it waiting for something, or maybe it can be merged?

It's complicated. This fix is tied to a fix that currently only lives in storybook 7. If this change was merged, it'd bring a regression for 6.5 users (as I mentioned above). What I'm hoping for is to patch the interaction fix back to Storybook 6.5, and then everything would become much simpler (though could still impact 6.4 users). Cc @shilman

We're currently using a release of this PR in 0.0.14-next.0 in the storybook monorepo :s

[IanVS]

As we approach 7.0 beta, whats the plan for this PR?

[github-actions]

🚀 PR was released in v0.1.0 🚀