Angular: Fix webpackStatsJson types in angular-builder #20296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
shilman
changed the title
|
Any chance we can get this in current stable version? We can't move our production app to use beta version and without this Turbosnap is a non-starter. |
shilman
added
the
patch:yes
|
@bmayen will do |
|
Thanks! Was opening a PR when I saw someone beat me to it #20503 |
shilman
added
patch:done
shilman
added a commit
that referenced
this pull request
Jan 11, 2023
…k-stats-json-schema Angular: Fix webpackStatsJson types in angular-builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Added "string" as a permissible type for the
webpackStatsJsonoption of the angular-builder to match the actual allowed type of the option in the CLI (webpackStatsJson?: string | boolean;).Without this, the Chromatic builder is failing when the
--only-changedflag is set, because it passes a string as a value towebpackStatsJson. The error given is:How to test
If your answer is yes to any of these, please make sure to include it in your PR.