fix(upgrade): dont upgrade nx packages #22419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
reviewed
May 5, 2023
mandarini
force-pushed
the
fix/dont-upgrade-nx
branch
from
e03f684 to
6f99cfc
Compare
mandarini
force-pushed
the
fix/dont-upgrade-nx
branch
from
6f99cfc to
9b90b36
Compare
yannbf
added
maintenance
mandarini
force-pushed
the
fix/dont-upgrade-nx
branch
2 times, most recently
from
ea52c6b to
5aa1ea5
Compare
|
@yannbf I updated the code so as not to override the existing |
mandarini
force-pushed
the
fix/dont-upgrade-nx
branch
from
5aa1ea5 to
ddb27d4
Compare
mandarini
commented
May 5, 2023
mandarini
force-pushed
the
fix/dont-upgrade-nx
branch
2 times, most recently
from
e37fe62 to
81b3f6e
Compare
mandarini
force-pushed
the
fix/dont-upgrade-nx
branch
from
81b3f6e to
9bd3dca
Compare
|
Hello @yannbf ! Is this good to go, after my latest updates? |
ndelangen
approved these changes
May 22, 2023
|
I'm looking at this today @mandarini |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
May 22, 2023
fix(upgrade): dont upgrade nx packages
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When upgrading, do not upgrade the
@nrwl/storybookand@nx/storybookpackages.How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]