Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat.channel.getUserInfo() returns null in openchatroom upper then 1300 people. #144

Closed
samknp opened this issue Feb 16, 2021 · 12 comments
Closed
Labels
approved Issue approved and have plan to fix or enhancement bug Something isn't working dev Issue related to development branch help wanted Extra attention is needed

Comments

@samknp
Copy link

samknp commented Feb 16, 2021

Describe the bug
chat.channel.getUserInfo() returns null in openchatroom upper then 1300 people.
Same as #75

To Reproduce
openchatroom with more then 1300 people participated.
function checkText(chat){ const userInfo = chat.Channel.getUserInfo(chat.Sender); }

Expected behavior
It should return information about chat.sender.

nodekakao version
nodekakao 3.1.8 version

@samknp samknp added the bug Something isn't working label Feb 16, 2021
@storycraft
Copy link
Owner

I changed initializing logic in #75 andh checked it working. There were some case reported Userinfo initialize failing like this. Unfortunately I don't have any "openchat" room over 1000 people.

@storycraft storycraft added the help wanted Extra attention is needed label Feb 16, 2021
@storycraft
Copy link
Owner

If you can, can you test if it fail same in 4.0.0-beta.5?

@storycraft storycraft added the approved Issue approved and have plan to fix or enhancement label Feb 16, 2021
@nunnu1028
Copy link

4.0.0 에서는 userInfo가 잘 나옵니다만, 3.1.8 에서는 아직도 고쳐지지 않은듯 하네요

@nunnu1028
Copy link

3.1.10에서 테스트결과 잘나옵니다.

@storycraft
Copy link
Owner

#75 이후 작동하는것이 확인되었지만, 일부 채팅방에서 제대로 작동하지 않는듯 합니다.

@samknp
Copy link
Author

samknp commented Feb 16, 2021

3.1.10에서 테스트결과 잘나옵니다.

3.1.8 버전 이후로는 4.0.5 beta로 넘어가는거 아닌가요?
3.1.10 버전도 있나요?

@nunnu1028
Copy link

nunnu1028 commented Feb 16, 2021

3.1.10에서 테스트결과 잘나옵니다.

3.1.8 버전 이후로는 4.0.5 beta로 넘어가는거 아닌가요?
3.1.10 버전도 있나요?

3.1.10 어제인가 오늘 나왔습니다.

#75 이후 작동하는것이 확인되었지만, 일부 채팅방에서 제대로 작동하지 않는듯 합니다.

아마 3.1.10에서도 일부 채팅방에서는 제대로 작동하지 않을 수 있습니다.

@samknp
Copy link
Author

samknp commented Feb 16, 2021

If you can, can you test if it fail same in 4.0.0-beta.5?

Sure. I already ready to test with 4.0.5 version.
I will report here after the testing.

@samknp
Copy link
Author

samknp commented Feb 17, 2021

If you can, can you test if it fail same in 4.0.0-beta.5?

It returns undefined. in node-kakao@4.0.0-beta.4 And also 3.1.10.
Same Issue.

@storycraft storycraft added the dev Issue related to development branch label Feb 17, 2021
@samknp
Copy link
Author

samknp commented Feb 18, 2021

추가 테스트 결과
1301명까지 pass
1321명이상 fail
100% 재현 이슈

@storycraft
Copy link
Owner

커밋 bd18590 이후 1400+명 방에서 작동 확인했습니다. rc.4 버전에서 다시 테스트 부탁드립니다

@samknp
Copy link
Author

samknp commented Feb 19, 2021

커밋 bd18590 이후 1400+명 방에서 작동 확인했습니다. rc.4 버전에서 다시 테스트 부탁드립니다

1336명방, 4.0.0_RC4 에서 테스트 결과
타인이 이야기 한것은 정상 리턴(기존에 undefined로 리턴하던 오류 수정됨)
그러나 본인(로그인 된 계정)이 이야기 할 경우 여전히 undefined 로 리턴됨.
1300명 이하 방에서는 본인이 이야기 해도 userInfo 정상적으로 리턴됨
1300명 이상 방에서만 본인이 이야기 할 경우 undefined로 리턴됨.

storycraft added a commit that referenced this issue Feb 19, 2021
Request client userinfo if olu is null and mi does not contains client user id. #144
Update to 4.0.0-rc.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Issue approved and have plan to fix or enhancement bug Something isn't working dev Issue related to development branch help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants