Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User join/quit events does not handled properly #38

Closed
storycraft opened this issue Jun 16, 2020 · 2 comments · Fixed by #39
Closed

User join/quit events does not handled properly #38

storycraft opened this issue Jun 16, 2020 · 2 comments · Fixed by #39
Labels
approved Issue approved and have plan to fix or enhancement bug Something isn't working

Comments

@storycraft
Copy link
Owner

Describe the bug
User join/quit events does not handled properly on open chat

To Reproduce

  1. User joins open chat
  2. Receive message from new channel.
  3. Client fail or throw error when try to get userinfo

Expected behavior
'user_join', 'user_left' events invoked properly and channel handle new userinfo
@storycraft storycraft added the bug Something isn't working label Jun 16, 2020
@storycraft storycraft mentioned this issue Jun 16, 2020
Closed
16 tasks
storycraft added a commit that referenced this issue Jun 19, 2020
@storycraft
optimize inner processing, removing async as possible
a923d92 
fix #38
@storycraft storycraft mentioned this issue Jun 21, 2020
Merged
16 tasks
@storycraft storycraft added the approved Issue approved and have plan to fix or enhancement label Jun 29, 2020
@storycraft
Copy link
Owner Author

reopen issue

@storycraft storycraft reopened this Jul 7, 2020
@storycraft storycraft changed the title User join/quit events does not handled properly on open chat User join/quit events does not handled properly Jul 7, 2020
storycraft added a commit that referenced this issue Jul 7, 2020
@storycraft
handle new channel on MSG
15ef7b3 
fix #38
check LEAVE response status code
@storycraft
Copy link
Owner Author

Issue moved to #49

@storycraft storycraft mentioned this issue Jul 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved Issue approved and have plan to fix or enhancement bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NodeKakao v3 storycraft/node-kakao
NodeKakao v3 [Invalid] storycraft/node-kakao
1 participant
@storycraft