Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to secrecy 0.10. #543

Closed
wants to merge 1 commit into from
Closed

Update to secrecy 0.10. #543

wants to merge 1 commit into from

Conversation

tmpfs
Copy link

@tmpfs tmpfs commented Oct 26, 2024

Requires pointing to a git dependency of pinentry for now which also needs updating.

One test (gen-stdout.toml) is failing using cargo +stable test but it also fails on main so I don't think it was introduced by these changes.

@str4d, if we can get a new version of pinentry published I can update the PR to remove the git dependency.

Requires pointing to a git dependency of pinentry for now which also
needs updating.
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.

Project coverage is 51.26%. Comparing base (baf277a) to head (766a3ed).

Files with missing lines Patch % Lines
age/src/ssh/identity.rs 0.00% 6 Missing ⚠️
age/src/cli_common.rs 0.00% 3 Missing ⚠️
age-plugin/src/identity.rs 0.00% 1 Missing ⚠️
age-plugin/src/recipient.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   50.97%   51.26%   +0.28%     
==========================================
  Files          43       43              
  Lines        4159     4163       +4     
==========================================
+ Hits         2120     2134      +14     
+ Misses       2039     2029      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@str4d
Copy link
Owner

str4d commented Nov 3, 2024

Replaced by #544 (which migrates to using the new secrecy APIs to reduce leakage of keys onto the stack).

@str4d str4d closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants