-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if compiler supports it use C++11 #223
if compiler supports it use C++11 #223
Conversation
@bbferka Thank you for sending a pull request! Just one question, is it possible to enable/disable c++11 features using something like |
@furushchev I guess that is also possible. Since indigo only works with Ubuntu 14.04, which comes with an old gcc, |
@bbferka Cool! I think it is enough just to add it as a comment to |
@furushchev sorry, I was mistaken. gcc 4.8 already has C++11 support. I will change my code to use the |
What about future releases? The current setup means we have to manually add each new ROS release that supports C++11. Wouldn't it be better to check the negative, e.g. if indigo then c++11 is disabled, else all other releases have it enabled? |
@hawesie you're right. I just changed the check; |
Tests pass. All is well. Thanks @bbferka |
@hawesie Could you release the new version including this change? I think it is not a small change, so recommend to increment a major or minor version (more than usual updates). |
ok, it's on my list for today |
@furushchev @hawesie thanks for merging! |
added compilation flags for C++11