Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring and preparing release #43

Closed
marc-hanheide opened this issue Sep 2, 2014 · 12 comments
Closed

refactoring and preparing release #43

marc-hanheide opened this issue Sep 2, 2014 · 12 comments
Assignees

Comments

@marc-hanheide
Copy link
Member

This repository needs a little restructuring according to the plans outlined in https://github.com/strands-project/strands_management/wiki/software-distribution

The idea is that it is pure configuration repository with launch files and parameter files that is specific to the scitos robot. So, it should only contain parameters and launch files for move_base on scitos, everyting else (src, and 3D stuff) to be moved to new repo strands_movebase without scitos prefix (use strands only if needed).

Once this is complete, the repository's dependencies should be checked and it should be released as outlined in https://github.com/strands-project/strands_management/wiki/STRANDS-release-procedures

@nilsbore
Copy link
Member

nilsbore commented Sep 2, 2014

So configuration files and launch files for 3d move_base should also go in the strands_movebase repo? Or should scitos_2d_navigation depend on strands_movebase? Also, I think it looks good to put the calibrate_chest in the strands_movebase repo. But the chest_calibration_publisher should always be run at robot startup (otherwise we don't have a valid tf) so scitos.launch would still have to include it.

@marc-hanheide
Copy link
Member Author

I think the plan is that scitos_2d_navigation is only about the parameters for having a 2D navigation without any Kinect etc. So, also the launch file including the chest_calibration_publisher should go into strands_movebase. This one should in @hawesie and my view only have stuff in it to run move_base on a scitos robot. The other stuff are our own extensions if that makes sense?

@nilsbore
Copy link
Member

nilsbore commented Sep 2, 2014

Yeah, I think it does, thanks for clarifying.

@nilsbore
Copy link
Member

nilsbore commented Sep 2, 2014

@hawesie , @marc-hanheide Could one of you guys create the repo and I'll do it in the next few days.

@marc-hanheide
Copy link
Member Author

done: https://github.com/strands-project/strands_movebase

you're also a member with write access, @nilsbore

@nilsbore
Copy link
Member

nilsbore commented Sep 2, 2014

Thanks!

@nilsbore
Copy link
Member

nilsbore commented Sep 3, 2014

Are we still supposed to work on the hydro-devel branch?

@marc-hanheide
Copy link
Member Author

I'd say so, yes!

@marc-hanheide
Copy link
Member Author

I have already entered this repo into the integration server, but not released anything (obviously). Most importantly, this package doesn't install anything yet. the install targets in CMakeLists.txt need to be filled properly.

@marc-hanheide
Copy link
Member Author

I should add that the package builds fine on the integration server, so all dependencies are correctly resolved. Well done!

See https://lcas.lincoln.ac.uk/jenkins/job/devel-hydro-scitos_2d_navigation/ARCH_PARAM=amd64,UBUNTU_PARAM=precise,label=devel/1/console

@nilsbore
Copy link
Member

nilsbore commented Dec 1, 2014

@marc-hanheide Close this?

@marc-hanheide
Copy link
Member Author

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants