Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to uv = 'discouraged` #21

Open
nsatragno opened this issue Jan 2, 2020 · 0 comments · May be fixed by #25
Open

Default to uv = 'discouraged` #21

nsatragno opened this issue Jan 2, 2020 · 0 comments · May be fixed by #25

Comments

@nsatragno
Copy link
Contributor

User verification should be set to discouraged by default. It should still be possible to set uv = 'required' with an option, but leaving it undefined can have unexpected side effects.
nsatragno added a commit to nsatragno/webauthn-node that referenced this issue Jan 6, 2020
@nsatragno
feat(WebAuthn): add an option for user verification
421171f 
Allow configuring the user verification requirement. This is implemented
as a boolean that is translated into either UserVerificationRequirement
"required" or "discouraged". Do not default to "preferred" since its
behaviour is confusing at best.

Fixes strangerlabs#21
@nsatragno nsatragno linked a pull request Jan 6, 2020 that will close this issue
Open
nsatragno added a commit to nsatragno/webauthn-node that referenced this issue Jan 27, 2020
@nsatragno
feat(WebAuthn): add an option for user verification
99626c6 
Allow configuring the user verification requirement. This is implemented
as a boolean that is translated into either UserVerificationRequirement
"required" or "discouraged". Do not default to "preferred" since its
behaviour is confusing at best.

Fixes strangerlabs#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(WebAuthn): add an option for user verification nsatragno/webauthn-node
1 participant
@nsatragno