-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract getting unique status result into a single method #430
base: master
Are you sure you want to change the base?
Conversation
8cbf1df
to
9d204d9
Compare
5417386
to
64d66a1
Compare
I just built a local copy of stratisd using this branch. I created a pool with 3 devices, started IO on the FS created from it and then took the block devices offline. The stratsd process printed:
Running the command line results in exception:
So we aren't panicing the stratisd process, but the CLI is not usable. |
|
@tasleson: Please add stratis-storage/stratisd#1449 to your stratisd install and see what the D-Bus tells us then. |
@mulkieran As requested
|
Bingo! I think this needs a separate issue since the problem that has been located has nothing to do with this PR. See #431. |
rebased. |
rebased. |
I think there's potential for a test, so pulling out of review... |
05e2ae3
to
feea886
Compare
This brings it into line with params, and is a bit better encapsulated. Signed-off-by: mulhern <amulhern@redhat.com>
rebased. |
Related: https://github.com/stratis-storage/stratisd/issues/794.
Related: #221.
The goals of this PR are:
The changes in behavior are:
EDIT: Comments:
properly belong to issue Devicemapper status ioctl sometimes returns a single word status "Error" #431, rather than to this PR.